Re: [PATCH 33/67] read_branches_file: replace strcpy with xstrdup

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 17, 2015, 16:53 UTC
Message-ID: <xmqqa8slj8cj.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20150917162447.GA25837@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 6 quoted lines

> Yeah, that was my thinking. Since I _did_ end up doing the cleanup and
> posted it earlier, please feel free to review and express an opinion on
> the original versus the cleanup.
>
> I'm on the fence.  I do think the cleaned-up version is much nicer, but
> I always worry about the risk of touching little-used code.

True.

With s/strbuf_read_file()/strbuf_getline()/ on the first one I think there is no regression (at least, that is the only deliberate regression I saw).

I found all other parts of the cleaned-up version much nicer, too.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.