Re: [PATCH 4/6] Squelch warning about an integer overflow
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 30, 2015, 18:21 UTC
- Message-ID
- <xmqqpozwkyj2.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <alpine.DEB.1.00.1510301918320.31610@s15462909.onlinehome-server.info>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 19 quoted lines
> Hi Junio, > > On Mon, 26 Oct 2015, Junio C Hamano wrote: > >> Johannes Schindelin <johannes.schindelin@gmx.de> writes: >> >> > We cannot rely on long integers to have more than 32 bits... >> > >> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> >> > --- >> >> Interesting. 8192 * 1024 * 1024 does not fit within 32-bit long, of >> course. Perhaps we can lose L after 1024 if we are explicitly >> saying that the result ought to be size_t (which may be larger than >> long)? > > Sure. But it would make the patch harder to read. > > Do you insist?
Not at all. I think the series is already in 'next', and if I haven't merged it yet, I should.