Re: [PATCH 3/6] Facilitate debugging Git executables in tests with gdb
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Oct 30, 2015, 18:55 UTC
- Message-ID
- <20151030185529.GH7881@google.com>
- In-Reply-To
- <alpine.DEB.1.00.1510301929020.31610@s15462909.onlinehome-server.info>
Johannes Schindelin wrote:
> On Tue, 27 Oct 2015, Johannes Schindelin wrote: >> On Mon, 26 Oct 2015, Jonathan Nieder wrote:
>>> Does the 'exec' after the fi need this as well? exec is supposed to >>> itself print a message and exit when it runs into an error.
[...]
> Actually, after reading the patch again, I think it is better to be less > intrusive and add the error message *just* for the gdb case, as it is > right now:
Why? Unlike the C library function of the same name, the shell builtin 'exec' prints an error message and exits on error.
Sorry for the lack of clarity, Jonathan