Re: [PATCH 3/6] Facilitate debugging Git executables in tests with gdb
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 30, 2015, 19:14 UTC
- Message-ID
- <alpine.DEB.1.00.1510302013340.31610@s15462909.onlinehome-server.info>
- In-Reply-To
- <20151030190256.GI7881@google.com>
Hi Jonathan,
On Fri, 30 Oct 2015, Jonathan Nieder wrote:
Show 22 quoted lines
> Junio C Hamano wrote: > > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > >> On Tue, 27 Oct 2015, Junio C Hamano wrote: > > >>> It can be called GDB=1, perhaps? > >> > >> No, this is way too generic. As I only test that the environment > >> variable's existence, even something like GDB=/usr/opt/gdb/bin/gdb would > >> trigger it. > >> > >> I could be talked into GDB_GIT=1, though. > > > > As I said in another message, I have no preference myself over the > > name of this variable (or making it a shell function like Duy > > mentioned, which incidentally may give us more visual pleasantness > > by losing '='). > > > > I'd just be happy as long as the feature becomes available, and I'd > > leave the choice of consistent and convenient naming to others who > > have stronger opinions ;-) > > Here's a suggested patch.
I am fine with this patch as a replacement for my original version.
Thanks, Dscho