Re: [PATCH 4/6] Squelch warning about an integer overflow

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 30, 2015, 18:18 UTC
Message-ID: <alpine.DEB.1.00.1510301918320.31610@s15462909.onlinehome-server.info>
In-Reply-To: <xmqqpp01fkg5.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Mon, 26 Oct 2015, Junio C Hamano wrote:

Show 11 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > We cannot rely on long integers to have more than 32 bits...
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> 
> Interesting.  8192 * 1024 * 1024 does not fit within 32-bit long, of
> course.  Perhaps we can lose L after 1024 if we are explicitly
> saying that the result ought to be size_t (which may be larger than
> long)?

Sure. But it would make the patch harder to read.

Do you insist?

Ciao, Dscho

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.