Re: [PATCH 2/2] t3404: add a test for the --gpg-sign option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 1, 2016, 16:06 UTC
- Message-ID
- <xmqqpoqxz6kp.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <alpine.DEB.2.20.1606301019040.12947@virtualbox>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 8 quoted lines
>> that has a substring '-S"' in it to ensure that the codepath to >> parse --gpg-sign= on the command line of "rebase", and to the >> message we see here are working correctly, without actually checking >> if GPG is invoked at all, or if it is invoked the key given by the >> option is correctly passed to the invocation? > > Exactly. I want to test --gpg-sign even when there is no gpg executable > available.
The other side of that coine is that even when GPG is available, we do not see if it is invoked correctly at all. That was what I found disturbing.