Re: [PATCH 1/2] t3404: fix another typo
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 29, 2016, 15:26 UTC
- Message-ID
- <xmqqlh1o584u.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <2ad336745e1b2a610b20b7cfba169bd3e042c178.1467210629.git.johannes.schindelin@gmx.de>
Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> The past tense of "to run" is "run", not "ran".
Actually, past tense of the verb "to run" is "ran" ;-) The reason why this patch is still correct is because this is writing in passive voice, where you want "be + past participle", and the past participle of the verb "to run" is "run".
Show 19 quoted lines
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > --- > t/t3404-rebase-interactive.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh > index 66348f1..c7ea8ba 100755 > --- a/t/t3404-rebase-interactive.sh > +++ b/t/t3404-rebase-interactive.sh > @@ -60,7 +60,7 @@ test_expect_success 'setup' ' > test_commit P fileP > ' > > -# "exec" commands are ran with the user shell by default, but this may > +# "exec" commands are run with the user shell by default, but this may > # be non-POSIX. For example, if SHELL=zsh then ">file" doesn't work > # to create a file. Unsetting SHELL avoids such non-portable behavior > # in tests. It must be exported for it to take effect where needed.