git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] t3404: add a test for the --gpg-sign option

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 6, 2016, 19:02 UTC
Message-ID
<xmqqmvlusi7v.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<alpine.DEB.2.20.1607061733200.6426@virtualbox>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 8 quoted lines
> Okay, so here is the deal: on the development machine where this was
> developed, I do not have gpg installed. So please take this test case just
> to make sure that things work as intended for the moment.
>
> Before sending the last rebase--helper patch series, I will make sure to
> add a real test that requires gpg, and submit that, too.
>
> Deal?
I do not particularly care if the latter one happens.

The only thing I care about is that the earlier round documents that we know we probably should test the real driving of the GPG program, but we deliberately do not do so in the series, and hint that such an enhancement can happen later.

That might even entice others to help writing a test or two ;-)
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 15 of 20 in “Late edits to the rebase -i tests”
  1. 0/2 Late edits to the rebase -i testsJohannes Schindelin, Jun 29, 2016
  2. 1/2 t3404: fix another typoJohannes Schindelin, Jun 29, 2016
  3. Junio C HamanoJun 29, 2016
  4. Johannes SchindelinJun 29, 2016
  5. Junio C HamanoJun 29, 2016
  6. Johannes SchindelinJun 30, 2016
  7. Pranit BauvaJun 29, 2016
  8. 2/2 t3404: add a test for the --gpg-sign optionJohannes Schindelin, Jun 29, 2016
  9. Junio C HamanoJun 29, 2016
  10. Johannes SchindelinJun 30, 2016
  11. Junio C HamanoJul 1, 2016
  12. Johannes SchindelinJul 2, 2016
  13. Junio C HamanoJul 6, 2016
  14. Johannes SchindelinJul 6, 2016
  15. Junio C HamanoJul 6, 2016
  16. Johannes SchindelinJul 7, 2016
  17. 0/3 Additional rebase -i testsJohannes Schindelin, Jul 7, 2016
  18. 2/3 rebase -i: demonstrate a bug with --autosquashJohannes Schindelin, Jul 7, 2016
  19. 1/3 t3404: add a test for the --gpg-sign optionJohannes Schindelin, Jul 7, 2016
  20. 3/3 rebase -i: we allow extra spaces after fixup!/squash!Johannes Schindelin, Jul 7, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.