git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/3] t3404: add a test for the --gpg-sign option

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 7, 2016, 15:52 UTC
Message-ID
<4fe1c1b7598f3c5ddc0cf8f9c0ef89ac193a22e2.1467906747.git.johannes.schindelin@gmx.de>
In-Reply-To
<cover.1467906747.git.johannes.schindelin@gmx.de>

For the upcoming rebase--helper work (which will accelerate the interactive rebase noticably), it is important to verify that the --gpg-sign option is handled properly.

Please note that this patch does this on the cheap, by verifying that the expected option is printed in the message of the 'edit' operation.

We really should test that the interactive rebase signs the commits properly, iff GPG is available. This test is left for later.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/t3404-rebase-interactive.sh | 8 ++++++++
 1 file changed, 8 insertions(+)
diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
index 66348f1..aa393d2 100755
--- a/t/t3404-rebase-interactive.sh
+++ b/t/t3404-rebase-interactive.sh
@@ -1281,4 +1281,12 @@ test_expect_success 'editor saves as CR/LF' '
 	)
 '
 
+SQ="'"
+test_expect_success 'rebase -i --gpg-sign=<key-id>' '
+	set_fake_editor &&
+	FAKE_LINES="edit 1" git rebase -i --gpg-sign="\"S I Gner\"" HEAD^ \
+		>out 2>err &&
+	grep "$SQ-S\"S I Gner\"$SQ" err
+'
+
 test_done
-- 
2.9.0.278.g1caae67
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 19 of 20 in “Late edits to the rebase -i tests”
  1. 0/2 Late edits to the rebase -i testsJohannes Schindelin, Jun 29, 2016
  2. 1/2 t3404: fix another typoJohannes Schindelin, Jun 29, 2016
  3. Junio C HamanoJun 29, 2016
  4. Johannes SchindelinJun 29, 2016
  5. Junio C HamanoJun 29, 2016
  6. Johannes SchindelinJun 30, 2016
  7. Pranit BauvaJun 29, 2016
  8. 2/2 t3404: add a test for the --gpg-sign optionJohannes Schindelin, Jun 29, 2016
  9. Junio C HamanoJun 29, 2016
  10. Johannes SchindelinJun 30, 2016
  11. Junio C HamanoJul 1, 2016
  12. Johannes SchindelinJul 2, 2016
  13. Junio C HamanoJul 6, 2016
  14. Johannes SchindelinJul 6, 2016
  15. Junio C HamanoJul 6, 2016
  16. Johannes SchindelinJul 7, 2016
  17. 0/3 Additional rebase -i testsJohannes Schindelin, Jul 7, 2016
  18. 2/3 rebase -i: demonstrate a bug with --autosquashJohannes Schindelin, Jul 7, 2016
  19. 1/3 t3404: add a test for the --gpg-sign optionJohannes Schindelin, Jul 7, 2016
  20. 3/3 rebase -i: we allow extra spaces after fixup!/squash!Johannes Schindelin, Jul 7, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.