git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] t3404: add a test for the --gpg-sign option

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 6, 2016, 15:34 UTC
Message-ID
<alpine.DEB.2.20.1607061733200.6426@virtualbox>
In-Reply-To
<xmqqeg76vmzb.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Wed, 6 Jul 2016, Junio C Hamano wrote:
Show 18 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Of course I agree that it would be very nice to have a test at a later
> > stage that does exercise GPG if it is available. But would it really
> > be so terrible to have a (simpler, not as complete) test that is
> > exercised *also* when GPG is *not* available?
> 
> What I would expect is "In the ideal world, we may want both, and in an
> imperfect world in which we can have only one, we'd rather have the
> 'even though we can run it only when GPG is available, we make sure that
> we drive GPG correctly' one, dropping the other.", simply because the
> end result matters more, not how the instruction to the end user is
> phrased.
> 
> Sure, in even less perfect world, having a superficial test might be
> better than nothing, but reminding ourselves to aim high (and make sure
> we document the decision when we punt) is an important part of the
> purpose of the review process, so...

Okay, so here is the deal: on the development machine where this was developed, I do not have gpg installed. So please take this test case just to make sure that things work as intended for the moment.

Before sending the last rebase--helper patch series, I will make sure to add a real test that requires gpg, and submit that, too.

Deal?

Ciao, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 14 of 20 in “Late edits to the rebase -i tests”
  1. 0/2 Late edits to the rebase -i testsJohannes Schindelin, Jun 29, 2016
  2. 1/2 t3404: fix another typoJohannes Schindelin, Jun 29, 2016
  3. Junio C HamanoJun 29, 2016
  4. Johannes SchindelinJun 29, 2016
  5. Junio C HamanoJun 29, 2016
  6. Johannes SchindelinJun 30, 2016
  7. Pranit BauvaJun 29, 2016
  8. 2/2 t3404: add a test for the --gpg-sign optionJohannes Schindelin, Jun 29, 2016
  9. Junio C HamanoJun 29, 2016
  10. Johannes SchindelinJun 30, 2016
  11. Junio C HamanoJul 1, 2016
  12. Johannes SchindelinJul 2, 2016
  13. Junio C HamanoJul 6, 2016
  14. Johannes SchindelinJul 6, 2016
  15. Junio C HamanoJul 6, 2016
  16. Johannes SchindelinJul 7, 2016
  17. 0/3 Additional rebase -i testsJohannes Schindelin, Jul 7, 2016
  18. 2/3 rebase -i: demonstrate a bug with --autosquashJohannes Schindelin, Jul 7, 2016
  19. 1/3 t3404: add a test for the --gpg-sign optionJohannes Schindelin, Jul 7, 2016
  20. 3/3 rebase -i: we allow extra spaces after fixup!/squash!Johannes Schindelin, Jul 7, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.