Re: [RFC PATCH v2] Allow aliases that include other aliases
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 5, 2018, 21:51 UTC
- Message-ID
- <xmqqpnxr396a.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180905173455.GA2336@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 13 quoted lines
>> This is what I've come up with to prevent looping aliases. I'm not too
>> happy with the number of indentations needed, but this seemed to be the
>> easiest way to search an array for a value.
>
> I think this approach is OK, though I wonder if we'd also be fine with
> just:
>
> if (done_alias++ > 100)
> die("woah, is your alias looping?");
>
> The point is just to prevent a runaway infinite loop, and this does that
> while keeping the cost very low for the common case (not that one string
> insertion is probably breaking the bank).Yeah, as a hack, I guess the simpler the solution, the better it would be.