Re: [PATCH] alias: detect loops in mixed execution mode

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 29, 2018, 03:44 UTC
Message-ID: <xmqqefc976x1.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181026083905.GA1705@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Hmph. So I was speaking before purely hypothetically, but now that your
> patch is in 'next', it is part of my daily build. And indeed, I hit a
> false positive within 5 minutes of building it. ;)

Sounds like somebody is having not-so-fun-a-time having "I told you so" moment. The 'dotgit' thing already feels bit convoluted but I would say that it is still within the realm of reasonable workflow elements.

Show 10 quoted lines

> ...
> With your patch, step 3 complains:
>
>   $ git dotgit ll
>   fatal: alias loop detected: expansion of 'dotgit' does not terminate:
>   dotgit <==
>   ll ==>
>
> So I would really prefer a depth counter that can be set sufficiently
> high to make this case work. ;)

Sounds like a concrete enough case to demonstrate why one-level deep loop detector is not sufficient X-<.