Re: [PATCH] alias: detect loops in mixed execution mode

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Oct 22, 2018, 21:28 UTC
Message-ID: <877ei9d634.fsf@evledraar.gmail.com>
In-Reply-To: <20181022211545.GA15713@sigill.intra.peff.net>

On Mon, Oct 22 2018, Jeff King wrote:

Show 10 quoted lines

> On Sat, Oct 20, 2018 at 09:18:21PM +0200, Ævar Arnfjörð Bjarmason wrote:
>
>> We didn't support chained aliases at all before, so I think the odds
>> that people will run into this now will increase as they add "!" to
>> existing aliases, and I'd like to have git's UI friendly enough to tell
>> users what went wrong by default, and not have to resort to the likes of
>> GIT_TRACE=1 which really should be left to powerusers.
>
> It's true that non-! aliases couldn't recurse before, but couldn't "!"
> ones always do so?

Yes. I meant that maybe now it's a feature that works for that people will start using it, and then convert some of that to !-aliases they wouldn't otherwise have written. Just idle speculation...