Re: [RFC PATCH v4 1/3] Add support for nested aliases

From: Tim Schumacher <timschumi@gmx.de>
Date: Sep 16, 2018, 07:46 UTC
Message-ID: <aede75a5-d2ba-5a95-434d-aa70f7270fd7@gmx.de>
In-Reply-To: <CACsJy8BnHgaphwy3beCCquFjU=SZebR2GvDCkFgh1_snxDBTRQ@mail.gmail.com>

On 08.09.18 15:28, Duy Nguyen wrote:

Show 9 quoted lines

> On Sat, Sep 8, 2018 at 12:44 AM Tim Schumacher <timschumi@gmx.de> wrote:
>> +               /*
>> +                * It could be an alias -- this works around the insanity
>>                   * of overriding "git log" with "git show" by having
>>                   * alias.log = show
>>                   */
> 
> I think this comment block is about the next two lines you just
> deleted. So delete it to instead of fixing style.

I think that comment is talking about the code that is handing the alias, so it still would be valid. The check might have peen placed in between to keep it logically grouped.

Show 7 quoted lines

> 
>> -               if (done_alias)
>> -                       break;
>>                  if (!handle_alias(argcp, argv))
>>                          break;
>>                  done_alias = 1;
>>          }