Re: [RFC PATCH v4 1/3] Add support for nested aliases

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 21, 2018, 15:59 UTC
Message-ID: <xmqqa7oayh7z.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <9f7aa1f1-2493-42f3-19b7-cfa2efadbb14@gmx.de>

Tim Schumacher <timschumi@gmx.de> writes:

Show 7 quoted lines

> it is located at the top of the while() loop. Giving an example is nice, but wouldn't
> it be better to say something like the following?
>
> 	/*
> 	 * Check if av[0] is a command before seeing if it is an
> 	 * alias to avoid taking over existing commands
> 	 */

If we have more concrete and constructive things to explain why we choose to forbid it, that may be worth saying, but I agree that it does not add much value to this comment to declare that an attempt to take over existing commands is "insane".

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.