Re: [PATCH 1/3] sha1dc: update from my PR #36
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 27, 2017, 18:12 UTC
- Message-ID
- <xmqqo9t91eqy.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <87zictjoff.fsf@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 20 quoted lines
> On Tue, Jun 27 2017, Junio C. Hamano jotted: > >> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: >> >>> Update sha1dc from my PR #36[1] which'll hopefully be integrated by >>> upstream soon. >> >> Please be careful about the title of the patch. "log --oneline" >> does not even let you tell your readers who calls this as "my" >> change, and readers would be clueless what PR #36 is. Something >> like >> >> sha1dc: correct endian detection for Solaris >> >> may give us more relevant information in the oneline output. > > Will fix. Can you integrate it as-is into pu anyway? I'm going to need > to re-submit it regardless once we get some testing on it & upstream > merges the PR, but having it in Travis et al in the meantime would be > great.
I somehow thought that your throwing a pull request at git.git would automatically trigger a Travis test, without you having to wait for me to do anything? Am I misinformed?