Re: [PATCH 1/3] sha1dc: update from my PR #36
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 27, 2017, 15:55 UTC
- Message-ID
- <xmqqefu52znl.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <xmqqmv8t317c.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 11 quoted lines
>> +#if (defined(__ARMEB__) || defined(__THUMBEB__) || defined(__AARCH64EB__) || \ >> defined(__MIPSEB__) || defined(__MIPSEB) || defined(_MIPSEB) || \ >> defined(__sparc)) >> +/* >> + * Should define Big Endian for a whitelist of known processors. See >> + * https://sourceforge.net/p/predef/wiki/Endianness/ and >> + * http://www.oracle.com/technetwork/server-storage/solaris/portingtosolaris-138514.html >> + */ >> #define SHA1DC_BIGENDIAN > > These look sensible.
By the way, I wonder why this didn't catch the sparc running Solaris. What does Michael's system use to let the software know that it is targetted for a Sparc, if not __sparc?