Re: [PATCH v3 2/3] sha1dc: optionally use sha1collisiondetection as a submodule

From: Stefan Beller <sbeller@google.com>
Date: Jul 5, 2017, 00:36 UTC
Message-ID: <CAGZ79kZqF3_PyrCnCMDyLNAUMRnvq96L3yoE0j=yzMigu4LUzg@mail.gmail.com>
In-Reply-To: <87fuebbyvl.fsf@gmail.com>

On Tue, Jul 4, 2017 at 3:50 PM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

>
> I think some invocation of "git submodule update ???" will do the same,
> but I can't from the docs see what that is right now.

'--remote' is what you are looking for.

When we have the branch field configured, the workflow for *creating* the patch sent to Junio might be different than it currently is. Currently, you would send a patch that is produced as:

  git -C sha1collisiondetection pull origin master
  git add sha1collisiondetection
  git commit -m "serious reasoning in the commit message"

This could be 'simplified' to

  git submodule update --remote
  git add sha1collisiondetection
  git commit -m "serious reasoning in the commit message"

but as we had different branches in the submodule field, I wonder how much of an ease this is.

For Junio the workflow stays the same, as he would just apply the patch, so I understand why he might see the branch field as pollution.