Re: [PATCH 1/3] sha1dc: update from my PR #36

From: Liam R. Howlett <liam.howlett@oracle.com>
Date: Jun 27, 2017, 16:31 UTC
Message-ID: <20170627163101.u7lsclnxnl6o7jec@oracle.com>
In-Reply-To: <xmqqefu52znl.fsf@gitster.mtv.corp.google.com>

* Junio C Hamano <gitster@pobox.com> [170627 11:55]:

Show 18 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
> >> +#if (defined(__ARMEB__) || defined(__THUMBEB__) || defined(__AARCH64EB__) || \
> >>       defined(__MIPSEB__) || defined(__MIPSEB) || defined(_MIPSEB) || \
> >>       defined(__sparc))
> >> +/*
> >> + * Should define Big Endian for a whitelist of known processors. See
> >> + * https://sourceforge.net/p/predef/wiki/Endianness/ and
> >> + * http://www.oracle.com/technetwork/server-storage/solaris/portingtosolaris-138514.html
> >> + */
> >>  #define SHA1DC_BIGENDIAN
> >
> > These look sensible.
> 
> By the way, I wonder why this didn't catch the sparc running
> Solaris.  What does Michael's system use to let the software know
> that it is targetted for a Sparc, if not __sparc?
>

I have issues running the test on my solaris system. Could you send him the changes you made on sha1dc in git? I suspect his platform does define __sparc.

Cheers, Liam