Re: Compile Error v2.13.2 on Solaris SPARC

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 27, 2017, 17:38 UTC
Message-ID: <xmqq1sq52uwj.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170627162808.p7sj3jpwum7n3hq2@oracle.com>

"Liam R. Howlett" <Liam.Howlett@Oracle.com> writes:

Show 18 quoted lines

> How about:
>
> ---- 8< ----
> diff --git a/sha1dc/sha1.c b/sha1dc/sha1.c
> index facea1bb5..ed8c63f2d 100644
> --- a/sha1dc/sha1.c
> +++ b/sha1dc/sha1.c
> @@ -38,9 +38,18 @@
>  
>  #if (defined(_BYTE_ORDER) || defined(__BYTE_ORDER) || defined(__BYTE_ORDER__))
>  
> +#define EMPTY_VAL(x) x ## 1
> +#define EMPTY(x) EMPTY_VAL(x)
> +
> +#if (defined(_BIG_ENDIAN) && (EMPTY(_BIG_ENDIAN) == 1))
> +#undef _BIG_ENDIAN
> +#define _BIG_ENDIAN 4321
> +#endif

I'd say it is a bad idea to define a symbol that you _know_ a platform header file defines. Any header you may include from the platform after these lines still expects the symbol to be defined in a way it defines without getting molested and will misbehave.