Re: [PATCH v16 Part II 2/8] bisect--helper: `bisect_write` shell function in C

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 27, 2017, 18:19 UTC
Message-ID: <xmqqo9osbghy.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <0102015f5e5ee22c-ea9c3a38-5d42-4dce-a54b-45c59768a70b-000000@eu-west-1.amazonses.com>

Pranit Bauva <pranit.bauva@gmail.com> writes:

> -		bisect_write "$state" "$rev"
> +		git bisect--helper --bisect-write "$state" "$rev" "$TERM_GOOD" "$TERM_BAD" || exit

I can see why two extra "terms" parameters need to be passed to this helper at this step; looking at patches around 4/8 and 6/8 where C code can directly find out what words are used for GOOD and BAD, we should be able to lose these two extra parameters from this helper by internally making a call to get_terms() from bisect_write() ;-)

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.