Re: [PATCH v16 Part II 2/8] bisect--helper: `bisect_write` shell function in C

From: Pranit Bauva <pranit.bauva@gmail.com>
Date: Oct 30, 2017, 17:38 UTC
Message-ID: <CAFZEwPOThFTLzfiPWs_2NVQ3BbQ26asTOyvGp72L-_OEuTfujQ@mail.gmail.com>
In-Reply-To: <xmqqo9osbghy.fsf@gitster.mtv.corp.google.com>

Hey Junio,

On Fri, Oct 27, 2017 at 11:49 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Pranit Bauva <pranit.bauva@gmail.com> writes:
>
>> -             bisect_write "$state" "$rev"
>> +             git bisect--helper --bisect-write "$state" "$rev" "$TERM_GOOD" "$TERM_BAD" || exit
>
> I can see why two extra "terms" parameters need to be passed to this
> helper at this step; looking at patches around 4/8 and 6/8 where C
> code can directly find out what words are used for GOOD and BAD, we
> should be able to lose these two extra parameters from this helper
> by internally making a call to get_terms() from bisect_write() ;-)

Yes quite true, but then after converting bisect_skip() we can completely get rid of this line and then it won't be needed in the ported C code.

PS: I have already ported that function but those patches are local as of now.

Regards, Pranit Bauva