Re: [PATCH v16 Part II 5/8] bisect--helper: `bisect_next_check` shell function in C

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 13, 2017, 03:56 UTC
Message-ID: <xmqqineeal29.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <214cfc63-79a8-a46f-4440-5e223186f2ff@gmx.net>

Stephan Beyer <s-beyer@gmx.net> writes:

Show 18 quoted lines

> Hi again ;)
> ...
> In both of the above "error" calls, you should drop the final "\n"
> because "error" does that already.
>
> On the other hand, you have dropped the "\n"s of the orginal error
> messages. So it should probably be
>
>  _("You need to give me at least one %s and %s revision.\n"
>    "You can use \"git bisect %s\" and \"git bisect %s\" for that.")
>
> and
>
>  _("You need to start by \"git bisect start\".\n"
>    "You then need to give me at least one %s and %s revision.\n"
>    "You can use \"git bisect %s\" and "\"git bisect %s\" for that.")
>
> Stephan

Thanks for reviews (not just this patch, but for reviews on other patches, too).