Re: [PATCH v16 Part II 6/8] bisect--helper: `get_terms` & `bisect_terms` shell function in C

From: Martin Ågren <martin.agren@gmail.com>
Date: Oct 27, 2017, 20:04 UTC
Message-ID: <CAN0heSrWbgNEfeXj0D0SBiyC_9i++qecBcb5Kuf4WtS1wFxKDQ@mail.gmail.com>
In-Reply-To: <0102015f5e5ee303-449f1b76-ff53-433c-8973-8b4850466810-000000@eu-west-1.amazonses.com>

On 27 October 2017 at 17:06, Pranit Bauva <pranit.bauva@gmail.com> wrote:

Show 5 quoted lines

> +       for (i = 0; i < argc; i++) {
> +               if (!strcmp(argv[i], "--term-good"))
> +                       printf(_("%s\n"), terms->term_good);
> +               else if (!strcmp(argv[i], "--term-bad"))
> +                       printf(_("%s\n"), terms->term_bad);

You seem to have lost --term-old and --term-new. I also wonder why these would need translating. You break GETTEXT_POISON here, then fix it in patch 8/8.

I'm not even sure you need patch 8/8. If I drop these two `_()`, I can run `git rebase -ix "make GETTEXT_POISON=Yes test"` on the entire series without failure. Patch 8/8 also switches to `test_i18ngrep` for some usages of `git branch` and for some checks on `.git/BISECT_START`. I'm not sure that's needed.

Show 6 quoted lines

> +               else
> +                       error(_("BUG: invalid argument %s for 'git bisect terms'.\n"
> +                                 "Supported options are: "
> +                                 "--term-good|--term-old and "
> +                                 "--term-bad|--term-new."), argv[i]);
> +       }