git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/1] submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 3, 2020, 00:20 UTC
Message-ID
<xmqqo8s91ktt.fsf@gitster.c.googlers.com>
In-Reply-To
<20200402225807.8603-1-shouryashukla.oo@gmail.com>
Shourya Shukla <shouryashukla.oo@gmail.com> writes:
Show 14 quoted lines
> Subcommands in 'submodule--helper.c' which give a callback to other functions
> have structures and macros named in the format: 'subcommand_cb' and 'SUBCOMMAND_CB_INIT'
> respectively.
>
> The subcommand 'foreach' did not follow this convention and therefore had the naming of
> the form: 'struct foreach_cb' and 'CB_FOREACH_INIT'. Rename these to: 'struct foreach_cb'
> and 'FOREACH_CB_INIT' respectively.
>
>
> Shourya Shukla (1):
>   submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'
>
>  builtin/submodule--helper.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
Isn't this already in 'master'?
Previous: Shourya ShuklaNext: Shourya Shukla
Message 3 of 5 in “submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'”
  1. 0/1 submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'Shourya Shukla, Apr 2, 2020
  2. 1/1 submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'Shourya Shukla, Apr 2, 2020
  3. Junio C HamanoApr 3, 2020
  4. Shourya ShuklaApr 3, 2020
  5. Junio C HamanoApr 3, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.