Re: [PATCH v3 0/9] Fix the early config

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 10, 2017, 16:39 UTC
Message-ID: <xmqqmvctytk0.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170309121620.rld6scydqru72nbk@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

>> > > Yes, exactly.  It would have been less confusing if I picked something
>> > > that passed nongit_ok. Like hash-object:
>> 
>> ... or like testing the early config directly?
>
> I was trying to demonstrate that the problem existed already without
> your patch series.

Yup, they are not new breakages introduced by Dscho's change.

Show 12 quoted lines

>> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>> Subject: [PATCH] t1309: document cases where we would want early config not to
>>  die()
>> 
>> Jeff King came up with a couple examples that demonstrate how the new
>> read_early_config() that looks harder for the current .git/ directory
>> could die() in an undesirable way.
>> 
>> Let's add those cases to the test script, to document what we would like
>> to happen when early config encounters problems.
>
> Yep, these all look fine.

OK.  Thanks, both.