Re: [PATCH v2 2/9] setup_git_directory(): use is_dir_sep() helper

> It is okay in practice to test for forward slashes in the output of
> getcwd(), because we go out of our way to convert backslashes to forward
> slashes in getcwd()'s output on Windows.
> 
> Still, the correct way to test for a dir separator is by using the
> helper function we introduced for that very purpose. It also serves as a
> good documentation what the code tries to do (not "how").

> @@ -910,7 +910,8 @@ static const char *setup_git_directory_gently_1(int *nongit_ok)
>  			return setup_bare_git_dir(&cwd, offset, nongit_ok);
>  
>  		offset_parent = offset;
> -		while (--offset_parent > ceil_offset && cwd.buf[offset_parent] != '/');
> +		while (--offset_parent > ceil_offset &&
> +		       !is_dir_sep(dir->buf[offset_parent]));