Re: [PATCH v2 2/9] setup_git_directory(): use is_dir_sep() helper

From: Jeff King <peff@peff.net>
Date: Mar 3, 2017, 11:26 UTC
Message-ID: <20170303112610.x6mdh42nd4hmxz2h@sigill.intra.peff.net>
In-Reply-To: <alpine.DEB.2.20.1703031212280.3767@virtualbox>

On Fri, Mar 03, 2017 at 12:16:31PM +0100, Johannes Schindelin wrote:

Show 6 quoted lines

> > What is "dir"? I'm guessing this patch got reordered and it should stay
> > as cwd.buf?
> 
> Oh drats. Usually I do a final `git rebase -x "make test" upstream/master`
> run before submitting, but I was really, really tired by the end of that
> stretch.

I usually do the same, and have done the "too tired" thing, too, only to have it bite me. That's why I so readily recognized the problem. :)

I've recently switched to using Michael's "git test" program[1], which caches the test results for each tree in a git-note. That makes the final "rebase -x" a lot less painful if you've left the early commits alone.

The python dependency might be a blocker for you, but I suspect the caching parts would be easy to hack together with shell.

-Peff

[1] https://github.com/mhagger/git-test