[PATCH v5 01/11] t7006: replace dubious test
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 9, 2017, 22:23 UTC
- Message-ID
- <9a8c14d065cc0dd63ef71c18b6047a9a9023dac3.1489098170.git.johannes.schindelin@gmx.de>
- In-Reply-To
- <cover.1489098170.git.johannes.schindelin@gmx.de>
The idea of the test case "git -p - core.pager is not used from subdirectory" was to verify that the setup_git_directory() function had not been called just to obtain the core.pager setting.
However, we are about to fix the early config machinery so that it *does* work, without messing up the global state.
Once that is done, the core.pager setting *will* be used, even when running from a subdirectory, and that is a Good Thing.
The intention of that test case, however, was to verify that the setup_git_directory() function has not run, because it changes global state such as the current working directory.
To keep that spirit, but fix the incorrect assumption, this patch replaces that test case by a new one that verifies that the pager is run in the subdirectory, i.e. that the current working directory has not been changed at the time the pager is configured and launched, even if the `rev-parse` command requires a .git/ directory and *will* change the working directory.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- t/t7006-pager.sh | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/t/t7006-pager.sh b/t/t7006-pager.sh index c8dc665f2fd..304ae06c600 100755 --- a/t/t7006-pager.sh +++ b/t/t7006-pager.sh @@ -378,9 +378,19 @@ test_GIT_PAGER_overrides expect_success test_must_fail 'git -p request-pull' test_default_pager expect_success test_must_fail 'git -p' test_PAGER_overrides expect_success test_must_fail 'git -p' test_local_config_ignored expect_failure test_must_fail 'git -p' -test_no_local_config_subdir expect_success test_must_fail 'git -p' test_GIT_PAGER_overrides expect_success test_must_fail 'git -p' +test_expect_failure TTY 'core.pager in repo config works and retains cwd' ' + sane_unset GIT_PAGER && + test_config core.pager "cat >cwd-retained" && + ( + cd sub && + rm -f cwd-retained && + test_terminal git -p rev-parse HEAD && + test_path_is_file cwd-retained + ) +' + test_doesnt_paginate expect_failure test_must_fail 'git -p nonsense' test_pager_choices 'git shortlog'
-- 2.12.0.windows.1.7.g94dafc3b124