Re: [PATCH v2 5/9] Make read_early_config() reusable

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 3, 2017, 14:11 UTC
Message-ID: <alpine.DEB.2.20.1703031511200.3767@virtualbox>
In-Reply-To: <20170303044630.tfogzhzbokuoiwh6@sigill.intra.peff.net>

Hi Peff,

On Thu, 2 Mar 2017, Jeff King wrote:

Show 13 quoted lines

> On Fri, Mar 03, 2017 at 03:04:20AM +0100, Johannes Schindelin wrote:
> 
> > The pager configuration needs to be read early, possibly before
> > discovering any .git/ directory.
> > 
> > Let's not hide this function in pager.c, but make it available to other
> > callers.
> > [...]
> > +	 * Note that this is a really dirty hack that does the wrong thing in
> > +	 * many cases. The crux of the problem is that we cannot run
> 
> Makes sense. I'll assume the words "dirty hack" disappear from this
> now-public function as you fix it up in a future patch. :)

Oops. I did not even think about that.

Fixed, Dscho

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.