Re: [PATCH v3 25/29] CI: set CC in MAKEFLAGS directly, don't add it to the environment

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 15, 2022, 16:59 UTC
Message-ID: <xmqqmtgme0zh.fsf@gitster.g>
In-Reply-To: <220415.86k0bqbgin.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> I'll fix that as along with any small follow-ups after this series,
> sound good?

Without any small follow-ups would be much much more preferrrable, and leave the follow-up to a separate series.

A series doing too many things at once can mix bad apples slip in by overwhelming the reviewer bandwidth, and I am afraid that it may be what happened in the original "bunch of Makefile updates" that the bug originated from. I am guessing that Carlo meant the same when he said "since there were too many refactorings around this code".

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.