Re: [PATCH v4 30/31] CI: have osx-gcc use gcc, not clang

From: Phillip Wood <phillip.wood@talktalk.net>
Date: Apr 18, 2022, 18:38 UTC
Message-ID: <55271bbe-7b6e-7c92-7337-2439a2f5be26@talktalk.net>
In-Reply-To: <patch-v4-30.31-94abb826627-20220418T132809Z-avarab@gmail.com>

On 18/04/2022 17:29, Ævar Arnfjörð Bjarmason wrote:

> Fix a regression in 707d2f2fe86 (CI: use "$runs_on_pool", not
> "$jobname" to select packages & config, 2021-11-23). In that commit I
> changed CC=gcc from CC=gcc-9, but on OSX the "gcc" in $PATH points to
> clang, we need to use gcc-9 instead.

As this is fixing a bug in master, perhaps it would be better as a separate patch that can be merged before this series (this series could be rebased on to the fix)

Best Wishes

Phillip

Show 19 quoted lines

> Reported-by: Carlo Arenas <carenas@gmail.com>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>   ci/lib.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ci/lib.sh b/ci/lib.sh
> index ab7546800e0..8f80be4c3df 100755
> --- a/ci/lib.sh
> +++ b/ci/lib.sh
> @@ -179,7 +179,7 @@ linux-TEST-vars)
>   	;;
>   osx-gcc)
>   	MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python3)"
> -	CC=gcc
> +	CC=gcc-9
>   	;;
>   osx-clang)
>   	MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python2)"