Re: [PATCH v3 25/29] CI: set CC in MAKEFLAGS directly, don't add it to the environment

From: Carlo Arenas <carenas@gmail.com>
Date: Apr 15, 2022, 20:28 UTC
Message-ID: <CAPUEspgWTk0wjmomo2g9TVHZny7stCt=B8D=HA2=gk_SEC5vnQ@mail.gmail.com>
In-Reply-To: <CAPUEspiE3HBkkBzNgz8Gb6=fc2NPnfbGzzn2SEiGGG+zVo9DLA@mail.gmail.com>

On Fri, Apr 15, 2022 at 12:03 PM Carlo Arenas <carenas@gmail.com> wrote:

Show 13 quoted lines

>
> On Fri, Apr 15, 2022 at 6:52 AM Ævar Arnfjörð Bjarmason
> <avarab@gmail.com> wrote:
> >
> > But unless I'm missing something that's already been the case on
> > "master" for a while, i.e. this is the master run showing that we'll
> > invoke "gcc":
> > https://github.com/git/git/runs/6031562726?check_suite_focus=true#step:3:6
>
> That would be unfortunate, considering the code in next (and all other
> not yet affected) branches still have the definition added in
> 176441bfb58 (ci: build Git with GCC 9 in the 'osx-gcc' build job,
> 2019-11-27) and which survived your travis-ci removal series.

Nevermind, my test was flawed, this[1] updated run does show this code was indeed refactored away and the bug also introduced to next and beyond.

Carlo

[1] https://github.com/carenas/git/runs/6042506530