git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 00/25] CI: run "make [test]" directly, use $GITHUB_ENV

From
PWPhillip Wood <phillip.wood123@gmail.com>
Date
Apr 18, 2022, 18:33 UTC
Message-ID
<e303769f-c008-8187-c20f-01a950657fed@gmail.com>
In-Reply-To
<320b3dde-a84e-0074-bed8-57061293b2b0@github.com>
Hi Ævar
On 25/03/2022 20:43, Victoria Dye wrote:
Show 43 quoted lines
> Ævar Arnfjörð Bjarmason wrote:
>> A re-roll of my improvements my series to simplify the CI setup a lot
>> (see diffstat), much of it was dealing with constraints that went away
>> with Travis et al. CI for this series (OSX runners failing for
>> unrelated reasons):
>>
>>      https://github.com/avar/git/actions/runs/2040223909
>>
>> For a much more detailed summary of how the output looks before/after
>> see v1[].
>>
>> This series heavily conflicts with Johannes's
>> js/ci-github-workflow-markup in "seen", but in the v1 I suggested
>> basing that series on top of this one, because it can benefit a lot
>> from these simplifications.
>>
>> I'll reply to this series with a proposed rebasing of that series on
>> top of this one, which allows for removing almost all of its changes
>> to "ci/" with no harm to its end-goals, i.e. the splitting up of
>> "make" and "make test" output is something it'll get for free from
>> this series.
>>
>> Junio: Since that series has been stalled on still-outstanding
>> performance issues for a couple of months I was hoping we could queue
>> this instead, and perhaps in addition if Johannes approves of the
>> proposed re-roll on top of his.
>>
>> There's some forward progress on the performance issues (this[2] reply
>> of Victoria Dye's from yesterday), but fully resolving those will
>> probably take a bit...
>>
>> Whereas even though this one is relatively large I don't think there's
>> anything controversial here. The one concern that's been raised has
>> been Johannes's objection to removing some of the dead Azure code
>> (which was needed to move forward here). I asked how he'd prefer to
>> move forward with that in [3], but there hasn't been a reply to that
>> in >1 month.
>>
> 
> While the largeness of a series shouldn't necessarily block it, the lack of
> overarching structure or purpose in this one makes it really difficult for
> me to review with much confidence (I can't speak for everyone, but it may be
> one of the reasons for the general lack of feedback).

That applies to me, I think this would be easier to follow if it was split up. As far as I can tell there are several groups of changes and I think it would be easier for reviewers if they were split into separate shorter series.

1. Split building git and running the tests into separate steps. This is
    I think the only user facing change. I think it is worthwhile and
    could be done in a single patch that just moved make test into a
    separate script without a lot of refactoring. In particular I do not
    see the need for separate steps that setup the environment for the
    build and tests (especially as the build environment variables are
    still present when the tests are run).
    Without the refactoring anyone resurrecting the azure pipelines for
    testing security fixes would easily be able to update those build
    definitions.
2. Moving the static analysis ci job into the Makefile. I'm not sure
    what the practical benefit of this is but it could be a self
    contained series.
3. Being able to run the ci scripts locally. Does this have a use beyond
    debugging them locally? Could this be implemented with a wrapper
    script rather than a large refactoring?
4. Cleanups. To be honest I think we could happily live without a some
    of these, especially patches 24-26 of v3 that rework code introduced
    in this series.

I see v4 has been posted while I was writing this and is even longer than v3.

Best Wishes
Phillip
Show 191 quoted lines
> If you believe all of
> these patches as thematically-related enough to warrant being in a single
> series, then it would help a lot if you could:
> 
> 1. Clearly describe the purpose of the series (yes they're all CI
>     improvements, but *why* these particular improvements, and why do they
>     all need to go together?)
> 2. Outline the "path" these commits take to accomplishing that purpose ("The
>     first 3 commits do X because Y. Then, the next 4 commits do A because B."
>     etc. or whatever format fits your writing style, as long as the
>     information is there).
> 3. Reorganize commits as necessary to keep the above outline from jumping
>     back and forth between topics.
> 
> Personally, I think this could (should?) be split into at least two series:
> one that breaks up 'run-build-and-tests.sh' (and is more directly relevant
> to dscho's series), and one that does the cleanup/flag change/other work.
> The two appear to be independent, and the resulting two series would be a
> much more manageable 10-15 commits each.
> 
>> I think just removing it is OK, we can always bring it back if needed,
>> and doing so is actually going to be simpler on top of this since the
>> CI is now less special, and leans more heavily on the logic of our
>> normal build process.
>>
>> 1. https://lore.kernel.org/git/cover-00.25-00000000000-20220221T143936Z-avarab@gmail.com
>> 2. https://lore.kernel.org/git/6b83bb83-32b9-20c9-fa02-c1c3170351c3@github.com/
>> 3. https://lore.kernel.org/git/220222.86y2236ndp.gmgdl@evledraar.gmail.com/
>>
>> Ævar Arnfjörð Bjarmason (25):
>>    CI: run "set -ex" early in ci/lib.sh
>>    CI: make "$jobname" explicit, remove fallback
>>    CI: remove more dead Travis CI support
>>    CI: remove dead "tree skipping" code
>>    CI: remove unused Azure ci/* code
>>    CI: don't have "git grep" invoke a pager in tree content check
>>    CI: have "static-analysis" run a "make ci-static-analysis" target
>>    CI: have "static-analysis" run "check-builtins", not "documentation"
>>    CI: move p4 and git-lfs variables to ci/install-dependencies.sh
>>    CI: consistently use "export" in ci/lib.sh
>>    CI: export variables via a wrapper
>>    CI: remove "run-build-and-tests.sh", run "make [test]" directly
>>    CI: check ignored unignored build artifacts in "win[+VS] build" too
>>    CI: invoke "make artifacts-tar" directly in windows-build
>>    CI: split up and reduce "ci/test-documentation.sh"
>>    CI: combine ci/install{,-docker}-dependencies.sh
>>    CI: move "env" definitions into ci/lib.sh
>>    ci/run-test-slice.sh: replace shelling out with "echo"
>>    CI: pre-select test slice in Windows & VS tests
>>    CI: only invoke ci/lib.sh as "steps" in main.yml
>>    CI: narrow down variable definitions in --build and --test
>>    CI: add more variables to MAKEFLAGS, except under vs-build
>>    CI: set CC in MAKEFLAGS directly, don't add it to the environment
>>    CI: set PYTHON_PATH setting for osx-{clang,gcc} into "$jobname" case
>>    CI: don't use "set -x" in "ci/lib.sh" output
>>
>>   .github/workflows/main.yml            | 100 +++++---
>>   Makefile                              |  31 ++-
>>   ci/check-directional-formatting.bash  |   2 +-
>>   ci/check-unignored-build-artifacts.sh |  20 ++
>>   ci/install-dependencies.sh            |  53 ++++-
>>   ci/install-docker-dependencies.sh     |  22 --
>>   ci/lib-ci-type.sh                     |  10 +
>>   ci/lib-tput.sh                        |   2 +
>>   ci/lib.sh                             | 316 +++++++++++++-------------
>>   ci/make-test-artifacts.sh             |  12 -
>>   ci/mount-fileshare.sh                 |  25 --
>>   ci/print-test-failures.sh             |  16 +-
>>   ci/run-build-and-tests.sh             |  54 -----
>>   ci/run-docker-build.sh                |  66 ------
>>   ci/run-docker.sh                      |  47 ----
>>   ci/run-static-analysis.sh             |  32 ---
>>   ci/run-test-slice.sh                  |  17 --
>>   ci/select-test-slice.sh               |  10 +
>>   ci/test-documentation.sh              |  37 +--
>>   ci/util/extract-trash-dirs.sh         |  50 ----
>>   shared.mak                            |   1 +
>>   21 files changed, 346 insertions(+), 577 deletions(-)
>>   create mode 100755 ci/check-unignored-build-artifacts.sh
>>   delete mode 100755 ci/install-docker-dependencies.sh
>>   create mode 100644 ci/lib-ci-type.sh
>>   create mode 100644 ci/lib-tput.sh
>>   delete mode 100755 ci/make-test-artifacts.sh
>>   delete mode 100755 ci/mount-fileshare.sh
>>   delete mode 100755 ci/run-build-and-tests.sh
>>   delete mode 100755 ci/run-docker-build.sh
>>   delete mode 100755 ci/run-docker.sh
>>   delete mode 100755 ci/run-static-analysis.sh
>>   delete mode 100755 ci/run-test-slice.sh
>>   create mode 100755 ci/select-test-slice.sh
>>   delete mode 100755 ci/util/extract-trash-dirs.sh
>>
>> Range-diff against v1:
>>   1:  970849a227f =  1:  4addbd70213 CI: run "set -ex" early in ci/lib.sh
>>   2:  eda7fb18064 =  2:  b23aa99fd37 CI: make "$jobname" explicit, remove fallback
>>   3:  3ee32815cf3 =  3:  eec15a95879 CI: remove more dead Travis CI support
>>   4:  c81c1b3f504 =  4:  73c894f1665 CI: remove dead "tree skipping" code
>>   5:  4738a22a36d =  5:  b5e6d538554 CI: remove unused Azure ci/* code
>>   6:  59e4f41e86c =  6:  a4b9febbdca CI: don't have "git grep" invoke a pager in tree content check
>>   7:  836ef20fdcc !  7:  5d46d5b34c9 CI: have "static-analysis" run a "make ci-static-analysis" target
>>      @@ .github/workflows/main.yml: jobs:
>>            if: needs.ci-config.outputs.enabled == 'yes'
>>       
>>        ## Makefile ##
>>      -@@ Makefile: ifndef V
>>      - 	QUIET_HDR      = @echo '   ' HDR $(<:hcc=h);
>>      - 	QUIET_RC       = @echo '   ' RC $@;
>>      - 	QUIET_SPATCH   = @echo '   ' SPATCH $<;
>>      -+	QUIET_CHECK    = @echo '   ' CHECK $@;
>>      - 	QUIET_SUBDIR0  = +@subdir=
>>      - 	QUIET_SUBDIR1  = ;$(NO_SUBDIR) echo '   ' SUBDIR $$subdir; \
>>      - 			 $(MAKE) $(PRINT_DIR) -C $$subdir
>>       @@ Makefile: coccicheck: $(addsuffix .patch,$(filter-out %.pending.cocci,$(wildcard contrib/c
>>        # See contrib/coccinelle/README
>>        coccicheck-pending: $(addsuffix .patch,$(wildcard contrib/coccinelle/*.pending.cocci))
>>      @@ ci/run-static-analysis.sh (deleted)
>>       -
>>       -make hdr-check ||
>>       -exit 1
>>      +
>>      + ## shared.mak ##
>>      +@@ shared.mak: ifndef V
>>      + 	QUIET_HDR      = @echo '   ' HDR $(<:hcc=h);
>>      + 	QUIET_RC       = @echo '   ' RC $@;
>>      + 	QUIET_SPATCH   = @echo '   ' SPATCH $<;
>>      ++	QUIET_CHECK    = @echo '   ' CHECK $@;
>>      +
>>      + ## Used in "Documentation/Makefile"
>>      + 	QUIET_ASCIIDOC	= @echo '   ' ASCIIDOC $@;
>>   8:  95cd496868e =  8:  81e06f13d84 CI: have "static-analysis" run "check-builtins", not "documentation"
>>   9:  a1d0796259e =  9:  3be91c26d44 CI: move p4 and git-lfs variables to ci/install-dependencies.sh
>> 10:  b6a61a786c5 = 10:  9dc148341ba CI: consistently use "export" in ci/lib.sh
>> 11:  f2fcee5d6e4 = 11:  e9c7ba492e8 CI: export variables via a wrapper
>> 12:  dfd823f2e7d = 12:  86d5a48d59a CI: remove "run-build-and-tests.sh", run "make [test]" directly
>> 13:  46459fff296 = 13:  649ad1ae249 CI: check ignored unignored build artifacts in "win[+VS] build" too
>> 14:  aecd3ebaafe = 14:  b1b5b083389 CI: invoke "make artifacts-tar" directly in windows-build
>> 15:  4f1564af70f = 15:  dfa91ac8938 CI: split up and reduce "ci/test-documentation.sh"
>> 16:  868613a5b06 = 16:  ba4ed216769 CI: combine ci/install{,-docker}-dependencies.sh
>> 17:  5d854e8ff36 = 17:  b5e89a33340 CI: move "env" definitions into ci/lib.sh
>> 18:  a6106525b7f = 18:  571f4d0f441 ci/run-test-slice.sh: replace shelling out with "echo"
>> 19:  e9c6c4dd293 = 19:  2edea06ee4d CI: pre-select test slice in Windows & VS tests
>> 20:  40d86e8c1dc = 20:  ef9daa6882f CI: only invoke ci/lib.sh as "steps" in main.yml
>> 21:  abf9c504740 = 21:  44e3ace5fbe CI: narrow down variable definitions in --build and --test
>> 22:  9f4c2798a82 = 22:  5f56b922e08 CI: add more variables to MAKEFLAGS, except under vs-build
>> 23:  8a8b7ecf16b ! 23:  b45b7cec94e CI: stop over-setting the $CC variable
>>      @@ Metadata
>>       Author: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
>>       
>>        ## Commit message ##
>>      -    CI: stop over-setting the $CC variable
>>      +    CI: set CC in MAKEFLAGS directly, don't add it to the environment
>>       
>>      -    As detailed in 2c8921db2b8 (travis-ci: build with the right compiler,
>>      -    2019-01-17) the reason we started using $CC in $MAKEFLAGS as opposed
>>      -    to setting it in the environment was due to Travis CI clobbering $CC
>>      -    in the environment.
>>      +    Rather than pass a "$CC" and "$CC_PACKAGE" in the environment to be
>>      +    picked up in ci/lib.sh let's instead have ci/lib.sh itself add it
>>      +    directly to MAKEFLAGS.
>>       
>>      -    We don't need to set it unconditionally to accomplish that, but rather
>>      -    just have it set for those jobs that need them. E.g. the "win+VS
>>      -    build" job confusingly has CC=gcc set, even though it builds with
>>      -    MSVC.
>>      +    Setting CC=gcc by default made for confusing trace output, and since a
>>      +    preceding change to carry it and others over across "steps" in the
>>      +    GitHub CI it's been even more misleading.  E.g. the "win+VS build" job
>>      +    confusingly has CC=gcc set, even though it builds with MSVC.
>>      +
>>      +    Let's instead reply on the Makefile default of CC=cc, and only
>>      +    override it for those jobs where it's needed. This does mean that
>>      +    we'll need to set it for the "pedantic" job, which previously relied
>>      +    on the default CC=gcc in case "clang" become the default on that
>>      +    platform.
>>       
>>           This partially reverts my 707d2f2fe86 (CI: use "$runs_on_pool", not
>>           "$jobname" to select packages & config, 2021-11-23), i.e. we're now
>>      @@ ci/lib.sh: linux-TEST-vars)
>>        	setenv --test GIT_TEST_DEFAULT_HASH sha256
>>        	;;
>>        pedantic)
>>      ++	CC=gcc
>>      + 	# Don't run the tests; we only care about whether Git can be
>>      + 	# built.
>>      + 	setenv --build DEVOPTS pedantic
>>       @@ ci/lib.sh: linux-musl)
>>        	MAKEFLAGS="$MAKEFLAGS GIT_TEST_UTF8_LOCALE=C.UTF-8"
>>        	;;
>> 24:  d7b472b4a52 = 24:  06bf8d9f61b CI: set PYTHON_PATH setting for osx-{clang,gcc} into "$jobname" case
>> 25:  08a9776c259 = 25:  6dc96ba8b82 CI: don't use "set -x" in "ci/lib.sh" output
>
Previous: Ævar Arnfjörð BjarmasonNext: Junio C Hamano
Message 108 of 260 in “CI: run "make [test]" directly, use $GITHUB_ENV”
  1. 00/25 CI: run "make [test]" directly, use $GITHUB_ENVÆvar Arnfjörð Bjarmason, Feb 21, 2022
  2. 01/25 CI: run "set -ex" early in ci/lib.shÆvar Arnfjörð Bjarmason, Feb 21, 2022
  3. 02/25 CI: make "$jobname" explicit, remove fallbackÆvar Arnfjörð Bjarmason, Feb 21, 2022
  4. 03/25 CI: remove more dead Travis CI supportÆvar Arnfjörð Bjarmason, Feb 21, 2022
  5. 04/25 CI: remove dead "tree skipping" codeÆvar Arnfjörð Bjarmason, Feb 21, 2022
  6. 08/25 CI: have "static-analysis" run "check-builtins", not "documentation"Ævar Arnfjörð Bjarmason, Feb 21, 2022
  7. 06/25 CI: don't have "git grep" invoke a pager in tree content checkÆvar Arnfjörð Bjarmason, Feb 21, 2022
  8. 07/25 CI: have "static-analysis" run a "make ci-static-analysis" targetÆvar Arnfjörð Bjarmason, Feb 21, 2022
  9. 05/25 CI: remove unused Azure ci/* codeÆvar Arnfjörð Bjarmason, Feb 21, 2022
  10. Johannes SchindelinFeb 22, 2022
  11. Ævar Arnfjörð BjarmasonFeb 22, 2022
  12. Johannes SchindelinFeb 22, 2022
  13. Ævar Arnfjörð BjarmasonFeb 22, 2022
  14. 10/25 CI: consistently use "export" in ci/lib.shÆvar Arnfjörð Bjarmason, Feb 21, 2022
  15. 09/25 CI: move p4 and git-lfs variables to ci/install-dependencies.shÆvar Arnfjörð Bjarmason, Feb 21, 2022
  16. 11/25 CI: export variables via a wrapperÆvar Arnfjörð Bjarmason, Feb 21, 2022
  17. 19/25 CI: pre-select test slice in Windows & VS testsÆvar Arnfjörð Bjarmason, Feb 21, 2022
  18. 16/25 CI: combine ci/install{,-docker}-dependencies.shÆvar Arnfjörð Bjarmason, Feb 21, 2022
  19. 18/25 ci/run-test-slice.sh: replace shelling out with "echo"Ævar Arnfjörð Bjarmason, Feb 21, 2022
  20. 17/25 CI: move "env" definitions into ci/lib.shÆvar Arnfjörð Bjarmason, Feb 21, 2022
  21. 14/25 CI: invoke "make artifacts-tar" directly in windows-buildÆvar Arnfjörð Bjarmason, Feb 21, 2022
  22. 13/25 CI: check ignored unignored build artifacts in "win[+VS] build" tooÆvar Arnfjörð Bjarmason, Feb 21, 2022
  23. 12/25 CI: remove "run-build-and-tests.sh", run "make [test]" directlyÆvar Arnfjörð Bjarmason, Feb 21, 2022
  24. 15/25 CI: split up and reduce "ci/test-documentation.sh"Ævar Arnfjörð Bjarmason, Feb 21, 2022
  25. 20/25 CI: only invoke ci/lib.sh as "steps" in main.ymlÆvar Arnfjörð Bjarmason, Feb 21, 2022
  26. 21/25 CI: narrow down variable definitions in --build and --testÆvar Arnfjörð Bjarmason, Feb 21, 2022
  27. 22/25 CI: add more variables to MAKEFLAGS, except under vs-buildÆvar Arnfjörð Bjarmason, Feb 21, 2022
  28. 25/25 CI: don't use "set -x" in "ci/lib.sh" outputÆvar Arnfjörð Bjarmason, Feb 21, 2022
  29. 23/25 CI: stop over-setting the $CC variableÆvar Arnfjörð Bjarmason, Feb 21, 2022
  30. SZEDER GáborMar 5, 2022
  31. Ævar Arnfjörð BjarmasonMar 5, 2022
  32. 24/25 CI: set PYTHON_PATH setting for osx-{clang,gcc} into "$jobname" caseÆvar Arnfjörð Bjarmason, Feb 21, 2022
  33. Phillip WoodFeb 23, 2022
  34. Junio C HamanoFeb 23, 2022
  35. Ævar Arnfjörð BjarmasonFeb 23, 2022
  36. Johannes SchindelinMar 9, 2022
  37. 00/25 CI: run "make [test]" directly, use $GITHUB_ENVÆvar Arnfjörð Bjarmason, Mar 25, 2022
  38. 15/25 CI: split up and reduce "ci/test-documentation.sh"Ævar Arnfjörð Bjarmason, Mar 25, 2022
  39. 19/25 CI: pre-select test slice in Windows & VS testsÆvar Arnfjörð Bjarmason, Mar 25, 2022
  40. 16/25 CI: combine ci/install{,-docker}-dependencies.shÆvar Arnfjörð Bjarmason, Mar 25, 2022
  41. 08/25 CI: have "static-analysis" run "check-builtins", not "documentation"Ævar Arnfjörð Bjarmason, Mar 25, 2022
  42. 02/25 CI: make "$jobname" explicit, remove fallbackÆvar Arnfjörð Bjarmason, Mar 25, 2022
  43. 13/25 CI: check ignored unignored build artifacts in "win[+VS] build" tooÆvar Arnfjörð Bjarmason, Mar 25, 2022
  44. 17/25 CI: move "env" definitions into ci/lib.shÆvar Arnfjörð Bjarmason, Mar 25, 2022
  45. 24/25 CI: set PYTHON_PATH setting for osx-{clang,gcc} into "$jobname" caseÆvar Arnfjörð Bjarmason, Mar 25, 2022
  46. 05/25 CI: remove unused Azure ci/* codeÆvar Arnfjörð Bjarmason, Mar 25, 2022
  47. 25/25 CI: don't use "set -x" in "ci/lib.sh" outputÆvar Arnfjörð Bjarmason, Mar 25, 2022
  48. 12/25 CI: remove "run-build-and-tests.sh", run "make [test]" directlyÆvar Arnfjörð Bjarmason, Mar 25, 2022
  49. 07/25 CI: have "static-analysis" run a "make ci-static-analysis" targetÆvar Arnfjörð Bjarmason, Mar 25, 2022
  50. 01/25 CI: run "set -ex" early in ci/lib.shÆvar Arnfjörð Bjarmason, Mar 25, 2022
  51. 0/6 CI: js/ci-github-workflow-markup rebased on "use $GITHUB_ENV"Ævar Arnfjörð Bjarmason, Mar 25, 2022
  52. 4/6 ci: optionally mark up output in the GitHub workflowÆvar Arnfjörð Bjarmason, Mar 25, 2022
  53. 6/6 ci: call `finalize_test_case_output` a little laterÆvar Arnfjörð Bjarmason, Mar 25, 2022
  54. 1/6 ci: make it easier to find failed tests' logs in the GitHub workflowÆvar Arnfjörð Bjarmason, Mar 25, 2022
  55. 2/6 tests: refactor --write-junit-xml codeÆvar Arnfjörð Bjarmason, Mar 25, 2022
  56. 3/6 test(junit): avoid line feeds in XML attributesÆvar Arnfjörð Bjarmason, Mar 25, 2022
  57. 5/6 ci: use `--github-workflow-markup` in the GitHub workflowÆvar Arnfjörð Bjarmason, Mar 25, 2022
  58. 0/6 CI: js/ci-github-workflow-markup rebased on "use $GITHUB_ENV"Ævar Arnfjörð Bjarmason, Apr 13, 2022
  59. 2/6 tests: refactor --write-junit-xml codeÆvar Arnfjörð Bjarmason, Apr 13, 2022
  60. 1/6 ci: make it easier to find failed tests' logs in the GitHub workflowÆvar Arnfjörð Bjarmason, Apr 13, 2022
  61. 3/6 test(junit): avoid line feeds in XML attributesÆvar Arnfjörð Bjarmason, Apr 13, 2022
  62. 4/6 ci: optionally mark up output in the GitHub workflowÆvar Arnfjörð Bjarmason, Apr 13, 2022
  63. 6/6 ci: call `finalize_test_case_output` a little laterÆvar Arnfjörð Bjarmason, Apr 13, 2022
  64. 5/6 ci: use `--github-workflow-markup` in the GitHub workflowÆvar Arnfjörð Bjarmason, Apr 13, 2022
  65. Junio C HamanoApr 14, 2022
  66. Ævar Arnfjörð BjarmasonApr 14, 2022
  67. Junio C HamanoApr 14, 2022
  68. 00/10 CI: js/ci-github-workflow-markup rebased on "use $GITHUB_ENV"Ævar Arnfjörð Bjarmason, Apr 21, 2022
  69. 02/10 CI: add --exit-code to ci/print-test-failures.shÆvar Arnfjörð Bjarmason, Apr 21, 2022
  70. 01/10 CI: don't "cd" in ci/print-test-failures.shÆvar Arnfjörð Bjarmason, Apr 21, 2022
  71. 03/10 CI: don't include "test-results/" in ci/print-test-failures.sh outputÆvar Arnfjörð Bjarmason, Apr 21, 2022
  72. 04/10 CI: stop setting FAILED_TEST_ARTIFACTS N timesÆvar Arnfjörð Bjarmason, Apr 21, 2022
  73. 05/10 ci: make it easier to find failed tests' logs in the GitHub workflowÆvar Arnfjörð Bjarmason, Apr 21, 2022
  74. 06/10 tests: refactor --write-junit-xml codeÆvar Arnfjörð Bjarmason, Apr 21, 2022
  75. 07/10 test(junit): avoid line feeds in XML attributesÆvar Arnfjörð Bjarmason, Apr 21, 2022
  76. 09/10 ci: use `--github-workflow-markup` in the GitHub workflowÆvar Arnfjörð Bjarmason, Apr 21, 2022
  77. 08/10 ci: optionally mark up output in the GitHub workflowÆvar Arnfjörð Bjarmason, Apr 21, 2022
  78. 10/10 ci: call `finalize_test_case_output` a little laterÆvar Arnfjörð Bjarmason, Apr 21, 2022
  79. 00/14 CI: js/ci-github-workflow-markup rebased on "use $GITHUB_ENV"Ævar Arnfjörð Bjarmason, May 25, 2022
  80. 01/14 CI: don't "cd" in ci/print-test-failures.shÆvar Arnfjörð Bjarmason, May 25, 2022
  81. 02/14 CI: don't include "test-results/" in ci/print-test-failures.sh outputÆvar Arnfjörð Bjarmason, May 25, 2022
  82. 03/14 CI: stop setting FAILED_TEST_ARTIFACTS N timesÆvar Arnfjörð Bjarmason, May 25, 2022
  83. 04/14 tests: refactor --write-junit-xml codeÆvar Arnfjörð Bjarmason, May 25, 2022
  84. 05/14 test(junit): avoid line feeds in XML attributesÆvar Arnfjörð Bjarmason, May 25, 2022
  85. 06/14 ci: optionally mark up output in the GitHub workflowÆvar Arnfjörð Bjarmason, May 25, 2022
  86. 07/14 ci: make it easier to find failed tests' logs in the GitHub workflowÆvar Arnfjörð Bjarmason, May 25, 2022
  87. 08/14 ci(github): skip the logs of the successful test casesÆvar Arnfjörð Bjarmason, May 25, 2022
  88. 09/14 ci(github): skip "skip" tests in --github-workflow-markupÆvar Arnfjörð Bjarmason, May 25, 2022
  89. 10/14 ci(github): avoid printing test case preamble twiceÆvar Arnfjörð Bjarmason, May 25, 2022
  90. 11/14 ci(github): mention where the full logs can be foundÆvar Arnfjörð Bjarmason, May 25, 2022
  91. 12/14 ci: call `finalize_test_case_output` a little laterÆvar Arnfjörð Bjarmason, May 25, 2022
  92. 13/14 CI: make --github-workflow-markup ci-config, off by defaultÆvar Arnfjörð Bjarmason, May 25, 2022
  93. 14/14 CI: make the --github-workflow-markup "github" output the defaultÆvar Arnfjörð Bjarmason, May 25, 2022
  94. 11/25 CI: export variables via a wrapperÆvar Arnfjörð Bjarmason, Mar 25, 2022
  95. 14/25 CI: invoke "make artifacts-tar" directly in windows-buildÆvar Arnfjörð Bjarmason, Mar 25, 2022
  96. 10/25 CI: consistently use "export" in ci/lib.shÆvar Arnfjörð Bjarmason, Mar 25, 2022
  97. 09/25 CI: move p4 and git-lfs variables to ci/install-dependencies.shÆvar Arnfjörð Bjarmason, Mar 25, 2022
  98. 21/25 CI: narrow down variable definitions in --build and --testÆvar Arnfjörð Bjarmason, Mar 25, 2022
  99. 23/25 CI: set CC in MAKEFLAGS directly, don't add it to the environmentÆvar Arnfjörð Bjarmason, Mar 25, 2022
  100. 22/25 CI: add more variables to MAKEFLAGS, except under vs-buildÆvar Arnfjörð Bjarmason, Mar 25, 2022
  101. 20/25 CI: only invoke ci/lib.sh as "steps" in main.ymlÆvar Arnfjörð Bjarmason, Mar 25, 2022
  102. 04/25 CI: remove dead "tree skipping" codeÆvar Arnfjörð Bjarmason, Mar 25, 2022
  103. 03/25 CI: remove more dead Travis CI supportÆvar Arnfjörð Bjarmason, Mar 25, 2022
  104. 18/25 ci/run-test-slice.sh: replace shelling out with "echo"Ævar Arnfjörð Bjarmason, Mar 25, 2022
  105. 06/25 CI: don't have "git grep" invoke a pager in tree content checkÆvar Arnfjörð Bjarmason, Mar 25, 2022
  106. Victoria DyeMar 25, 2022
  107. Ævar Arnfjörð BjarmasonMar 26, 2022
  108. Phillip WoodApr 18, 2022
  109. Junio C HamanoMar 28, 2022
  110. Johannes SchindelinApr 5, 2022
  111. Ævar Arnfjörð BjarmasonApr 6, 2022
  112. Junio C HamanoApr 6, 2022
  113. 00/29 CI: run "make" in CI "steps", improve UXÆvar Arnfjörð Bjarmason, Apr 13, 2022
  114. 01/29 CI: run "set -ex" early in ci/lib.shÆvar Arnfjörð Bjarmason, Apr 13, 2022
  115. 02/29 CI: make "$jobname" explicit, remove fallbackÆvar Arnfjörð Bjarmason, Apr 13, 2022
  116. 03/29 CI: remove more dead Travis CI supportÆvar Arnfjörð Bjarmason, Apr 13, 2022
  117. Eric SunshineApr 14, 2022
  118. 04/29 CI: remove dead "tree skipping" codeÆvar Arnfjörð Bjarmason, Apr 13, 2022
  119. 05/29 CI: remove unused Azure ci/* codeÆvar Arnfjörð Bjarmason, Apr 13, 2022
  120. 06/29 CI/lib.sh: stop adding leading whitespace to $MAKEFLAGSÆvar Arnfjörð Bjarmason, Apr 13, 2022
  121. 07/29 CI: don't have "git grep" invoke a pager in tree content checkÆvar Arnfjörð Bjarmason, Apr 13, 2022
  122. Eric SunshineApr 14, 2022
  123. 08/29 CI: have "static-analysis" run a "make ci-static-analysis" targetÆvar Arnfjörð Bjarmason, Apr 13, 2022
  124. 10/29 CI: move p4 and git-lfs variables to ci/install-dependencies.shÆvar Arnfjörð Bjarmason, Apr 13, 2022
  125. 11/29 CI: consistently use "export" in ci/lib.shÆvar Arnfjörð Bjarmason, Apr 13, 2022
  126. 09/29 CI: have "static-analysis" run "check-builtins", not "documentation"Ævar Arnfjörð Bjarmason, Apr 13, 2022
  127. 12/29 CI: export variables via a wrapperÆvar Arnfjörð Bjarmason, Apr 13, 2022
  128. 14/29 ci/lib.sh: use "test" instead of "["Ævar Arnfjörð Bjarmason, Apr 13, 2022
  129. 15/29 CI: check ignored unignored build artifacts in "win[+VS] build" tooÆvar Arnfjörð Bjarmason, Apr 13, 2022
  130. 16/29 CI: invoke "make artifacts-tar" directly in windows-buildÆvar Arnfjörð Bjarmason, Apr 13, 2022
  131. 13/29 CI: remove "run-build-and-tests.sh", run "make [test]" directlyÆvar Arnfjörð Bjarmason, Apr 13, 2022
  132. Eric SunshineApr 14, 2022
  133. 17/29 CI: split up and reduce "ci/test-documentation.sh"Ævar Arnfjörð Bjarmason, Apr 13, 2022
  134. Eric SunshineApr 14, 2022
  135. 18/29 CI: combine ci/install{,-docker}-dependencies.shÆvar Arnfjörð Bjarmason, Apr 13, 2022
  136. 19/29 CI: move "env" definitions into ci/lib.shÆvar Arnfjörð Bjarmason, Apr 13, 2022
  137. 20/29 ci/run-test-slice.sh: replace shelling out with "echo"Ævar Arnfjörð Bjarmason, Apr 13, 2022
  138. 21/29 CI: pre-select test slice in Windows & VS testsÆvar Arnfjörð Bjarmason, Apr 13, 2022
  139. 22/29 CI: only invoke ci/lib.sh as "steps" in main.ymlÆvar Arnfjörð Bjarmason, Apr 13, 2022
  140. 23/29 CI: narrow down variable definitions in --build and --testÆvar Arnfjörð Bjarmason, Apr 13, 2022
  141. 24/29 CI: add more variables to MAKEFLAGS, except under vs-buildÆvar Arnfjörð Bjarmason, Apr 13, 2022
  142. 26/29 CI: set SANITIZE=leak in MAKEFLAGS directlyÆvar Arnfjörð Bjarmason, Apr 13, 2022
  143. 25/29 CI: set CC in MAKEFLAGS directly, don't add it to the environmentÆvar Arnfjörð Bjarmason, Apr 13, 2022
  144. Eric SunshineApr 14, 2022
  145. Carlo ArenasApr 15, 2022
  146. Ævar Arnfjörð BjarmasonApr 15, 2022
  147. Junio C HamanoApr 15, 2022
  148. Carlo ArenasApr 15, 2022
  149. Carlo ArenasApr 15, 2022
  150. 27/29 CI: set PYTHON_PATH setting for osx-{clang,gcc} into "$jobname" caseÆvar Arnfjörð Bjarmason, Apr 13, 2022
  151. 28/29 CI: don't use "set -x" in "ci/lib.sh" outputÆvar Arnfjörð Bjarmason, Apr 13, 2022
  152. 29/29 CI: make it easy to use ci/*.sh outside of CIÆvar Arnfjörð Bjarmason, Apr 13, 2022
  153. Eric SunshineApr 14, 2022
  154. Ævar Arnfjörð BjarmasonApr 14, 2022
  155. Junio C HamanoApr 13, 2022
  156. 00/31 CI: run "make" in CI "steps", improve UXÆvar Arnfjörð Bjarmason, Apr 18, 2022
  157. 01/31 CI: run "set -ex" early in ci/lib.shÆvar Arnfjörð Bjarmason, Apr 18, 2022
  158. 02/31 CI: make "$jobname" explicit, remove fallbackÆvar Arnfjörð Bjarmason, Apr 18, 2022
  159. 03/31 CI: remove more dead Travis CI supportÆvar Arnfjörð Bjarmason, Apr 18, 2022
  160. 05/31 CI: remove unused Azure ci/* codeÆvar Arnfjörð Bjarmason, Apr 18, 2022
  161. 04/31 CI: remove dead "tree skipping" codeÆvar Arnfjörð Bjarmason, Apr 18, 2022
  162. 06/31 CI/lib.sh: stop adding leading whitespace to $MAKEFLAGSÆvar Arnfjörð Bjarmason, Apr 18, 2022
  163. 07/31 CI: don't have "git grep" invoke a pager in tree content checkÆvar Arnfjörð Bjarmason, Apr 18, 2022
  164. 08/31 CI: have "static-analysis" run a "make ci-static-analysis" targetÆvar Arnfjörð Bjarmason, Apr 18, 2022
  165. 13/31 CI: remove "run-build-and-tests.sh", run "make [test]" directlyÆvar Arnfjörð Bjarmason, Apr 18, 2022
  166. 14/31 ci/lib.sh: use "test" instead of "["Ævar Arnfjörð Bjarmason, Apr 18, 2022
  167. 12/31 CI: export variables via a wrapperÆvar Arnfjörð Bjarmason, Apr 18, 2022
  168. 11/31 CI: consistently use "export" in ci/lib.shÆvar Arnfjörð Bjarmason, Apr 18, 2022
  169. 16/31 CI: invoke "make artifacts-tar" directly in windows-buildÆvar Arnfjörð Bjarmason, Apr 18, 2022
  170. 17/31 CI: split up and reduce "ci/test-documentation.sh"Ævar Arnfjörð Bjarmason, Apr 18, 2022
  171. 19/31 CI: combine ci/install{,-docker}-dependencies.shÆvar Arnfjörð Bjarmason, Apr 18, 2022
  172. 18/31 CI: make ci/install-dependencies.sh POSIX-compatibleÆvar Arnfjörð Bjarmason, Apr 18, 2022
  173. 20/31 CI: move "env" definitions into ci/lib.shÆvar Arnfjörð Bjarmason, Apr 18, 2022
  174. 21/31 ci/run-test-slice.sh: replace shelling out with "echo"Ævar Arnfjörð Bjarmason, Apr 18, 2022
  175. 22/31 CI: pre-select test slice in Windows & VS testsÆvar Arnfjörð Bjarmason, Apr 18, 2022
  176. 25/31 CI: add more variables to MAKEFLAGS, except under vs-buildÆvar Arnfjörð Bjarmason, Apr 18, 2022
  177. 27/31 CI: set SANITIZE=leak in MAKEFLAGS directlyÆvar Arnfjörð Bjarmason, Apr 18, 2022
  178. 29/31 CI: don't use "set -x" in "ci/lib.sh" outputÆvar Arnfjörð Bjarmason, Apr 18, 2022
  179. 28/31 CI: set PYTHON_PATH setting for osx-{clang,gcc} into "$jobname" caseÆvar Arnfjörð Bjarmason, Apr 18, 2022
  180. 26/31 CI: set CC in MAKEFLAGS directly, don't add it to the environmentÆvar Arnfjörð Bjarmason, Apr 18, 2022
  181. 31/31 CI: make it easy to use ci/*.sh outside of CIÆvar Arnfjörð Bjarmason, Apr 18, 2022
  182. Eric SunshineApr 18, 2022
  183. Ævar Arnfjörð BjarmasonApr 19, 2022
  184. 09/31 CI: have "static-analysis" run "check-builtins", not "documentation"Ævar Arnfjörð Bjarmason, Apr 18, 2022
  185. 15/31 CI: check ignored unignored build artifacts in "win[+VS] build" tooÆvar Arnfjörð Bjarmason, Apr 18, 2022
  186. 10/31 CI: move p4 and git-lfs variables to ci/install-dependencies.shÆvar Arnfjörð Bjarmason, Apr 18, 2022
  187. 30/31 CI: have osx-gcc use gcc, not clangÆvar Arnfjörð Bjarmason, Apr 18, 2022
  188. Phillip WoodApr 18, 2022
  189. Junio C HamanoApr 20, 2022
  190. Phillip WoodApr 20, 2022
  191. Junio C HamanoApr 20, 2022
  192. js/ci-github-workflow-markup, was Re: [PATCH v4 30/31] CI: have osx-gcc use gcc, not clangJohannes Schindelin, Apr 21, 2022
  193. Ævar Arnfjörð BjarmasonApr 21, 2022
  194. Junio C HamanoApr 21, 2022
  195. 24/31 CI: narrow down variable definitions in --build and --testÆvar Arnfjörð Bjarmason, Apr 18, 2022
  196. 23/31 CI: only invoke ci/lib.sh as "steps" in main.ymlÆvar Arnfjörð Bjarmason, Apr 18, 2022
  197. 00/29 CI: run "make" in CI "steps", improve UXÆvar Arnfjörð Bjarmason, Apr 21, 2022
  198. 03/29 CI: remove more dead Travis CI supportÆvar Arnfjörð Bjarmason, Apr 21, 2022
  199. 01/29 CI: run "set -ex" early in ci/lib.shÆvar Arnfjörð Bjarmason, Apr 21, 2022
  200. 02/29 CI: make "$jobname" explicit, remove fallbackÆvar Arnfjörð Bjarmason, Apr 21, 2022
  201. 04/29 CI: remove dead "tree skipping" codeÆvar Arnfjörð Bjarmason, Apr 21, 2022
  202. 08/29 CI: have "static-analysis" run a "make ci-static-analysis" targetÆvar Arnfjörð Bjarmason, Apr 21, 2022
  203. 10/29 CI: move p4 and git-lfs variables to ci/install-dependencies.shÆvar Arnfjörð Bjarmason, Apr 21, 2022
  204. fixup! CI: move p4 and git-lfs variables to ci/install-dependencies.shCarlo Marcelo Arenas Belón, Apr 23, 2022
  205. Junio C HamanoApr 23, 2022
  206. Carlo ArenasApr 23, 2022
  207. Carlo ArenasApr 24, 2022
  208. 11/29 CI: consistently use "export" in ci/lib.shÆvar Arnfjörð Bjarmason, Apr 21, 2022
  209. 09/29 CI: have "static-analysis" run "check-builtins", not "documentation"Ævar Arnfjörð Bjarmason, Apr 21, 2022
  210. 12/29 CI: export variables via a wrapperÆvar Arnfjörð Bjarmason, Apr 21, 2022
  211. 07/29 CI: don't have "git grep" invoke a pager in tree content checkÆvar Arnfjörð Bjarmason, Apr 21, 2022
  212. 05/29 CI: remove unused Azure ci/* codeÆvar Arnfjörð Bjarmason, Apr 21, 2022
  213. 06/29 CI/lib.sh: stop adding leading whitespace to $MAKEFLAGSÆvar Arnfjörð Bjarmason, Apr 21, 2022
  214. 13/29 CI: remove "run-build-and-tests.sh", run "make [test]" directlyÆvar Arnfjörð Bjarmason, Apr 21, 2022
  215. 14/29 CI: make ci/{lib,install-dependencies}.sh POSIX-compatibleÆvar Arnfjörð Bjarmason, Apr 21, 2022
  216. 16/29 CI: invoke "make artifacts-tar" directly in windows-buildÆvar Arnfjörð Bjarmason, Apr 21, 2022
  217. 17/29 CI: split up and reduce "ci/test-documentation.sh"Ævar Arnfjörð Bjarmason, Apr 21, 2022
  218. 18/29 CI: combine ci/install{,-docker}-dependencies.shÆvar Arnfjörð Bjarmason, Apr 21, 2022
  219. 19/29 CI: move "env" definitions into ci/lib.shÆvar Arnfjörð Bjarmason, Apr 21, 2022
  220. 20/29 ci/run-test-slice.sh: replace shelling out with "echo"Ævar Arnfjörð Bjarmason, Apr 21, 2022
  221. 22/29 CI: only invoke ci/lib.sh as "steps" in main.ymlÆvar Arnfjörð Bjarmason, Apr 21, 2022
  222. 23/29 CI: narrow down variable definitions in --build and --testÆvar Arnfjörð Bjarmason, Apr 21, 2022
  223. 24/29 CI: add more variables to MAKEFLAGS, except under vs-buildÆvar Arnfjörð Bjarmason, Apr 21, 2022
  224. 26/29 CI: set SANITIZE=leak in MAKEFLAGS directlyÆvar Arnfjörð Bjarmason, Apr 21, 2022
  225. 25/29 CI: set CC in MAKEFLAGS directly, don't add it to the environmentÆvar Arnfjörð Bjarmason, Apr 21, 2022
  226. 28/29 CI: don't use "set -x" in "ci/lib.sh" outputÆvar Arnfjörð Bjarmason, Apr 21, 2022
  227. 15/29 CI: check ignored unignored build artifacts in "win[+VS] build" tooÆvar Arnfjörð Bjarmason, Apr 21, 2022
  228. 21/29 CI: pre-select test slice in Windows & VS testsÆvar Arnfjörð Bjarmason, Apr 21, 2022
  229. 27/29 CI: set PYTHON_PATH setting for osx-{clang,gcc} into "$jobname" caseÆvar Arnfjörð Bjarmason, Apr 21, 2022
  230. 29/29 CI: make it easy to use ci/*.sh outside of CIÆvar Arnfjörð Bjarmason, Apr 21, 2022
  231. 00/29 CI: run "make" in CI "steps", improve UXÆvar Arnfjörð Bjarmason, May 25, 2022
  232. 01/29 CI: run "set -ex" early in ci/lib.shÆvar Arnfjörð Bjarmason, May 25, 2022
  233. 02/29 CI: make "$jobname" explicit, remove fallbackÆvar Arnfjörð Bjarmason, May 25, 2022
  234. 05/29 CI: remove unused Azure ci/* codeÆvar Arnfjörð Bjarmason, May 25, 2022
  235. 03/29 CI: remove more dead Travis CI supportÆvar Arnfjörð Bjarmason, May 25, 2022
  236. 07/29 CI: don't have "git grep" invoke a pager in tree content checkÆvar Arnfjörð Bjarmason, May 25, 2022
  237. 04/29 CI: remove dead "tree skipping" codeÆvar Arnfjörð Bjarmason, May 25, 2022
  238. 09/29 CI: have "static-analysis" run "check-builtins", not "documentation"Ævar Arnfjörð Bjarmason, May 25, 2022
  239. 10/29 CI: move p4 and git-lfs variables to ci/install-dependencies.shÆvar Arnfjörð Bjarmason, May 25, 2022
  240. 11/29 CI: consistently use "export" in ci/lib.shÆvar Arnfjörð Bjarmason, May 25, 2022
  241. 26/29 CI: set SANITIZE=leak in MAKEFLAGS directlyÆvar Arnfjörð Bjarmason, May 25, 2022
  242. 24/29 CI: add more variables to MAKEFLAGS, except under vs-buildÆvar Arnfjörð Bjarmason, May 25, 2022
  243. 25/29 CI: set CC in MAKEFLAGS directly, don't add it to the environmentÆvar Arnfjörð Bjarmason, May 25, 2022
  244. 27/29 CI: set PYTHON_PATH setting for osx-{clang,gcc} into "$jobname" caseÆvar Arnfjörð Bjarmason, May 25, 2022
  245. 28/29 CI: don't use "set -x" in "ci/lib.sh" outputÆvar Arnfjörð Bjarmason, May 25, 2022
  246. 29/29 CI: make it easy to use ci/*.sh outside of CIÆvar Arnfjörð Bjarmason, May 25, 2022
  247. 06/29 CI/lib.sh: stop adding leading whitespace to $MAKEFLAGSÆvar Arnfjörð Bjarmason, May 25, 2022
  248. 08/29 CI: have "static-analysis" run a "make ci-static-analysis" targetÆvar Arnfjörð Bjarmason, May 25, 2022
  249. 12/29 CI: export variables via a wrapperÆvar Arnfjörð Bjarmason, May 25, 2022
  250. 17/29 CI: split up and reduce "ci/test-documentation.sh"Ævar Arnfjörð Bjarmason, May 25, 2022
  251. 15/29 CI: check ignored unignored build artifacts in "win[+VS] build" tooÆvar Arnfjörð Bjarmason, May 25, 2022
  252. 16/29 CI: invoke "make artifacts-tar" directly in windows-buildÆvar Arnfjörð Bjarmason, May 25, 2022
  253. 18/29 CI: combine ci/install{,-docker}-dependencies.shÆvar Arnfjörð Bjarmason, May 25, 2022
  254. 14/29 CI: make ci/{lib,install-dependencies}.sh POSIX-compatibleÆvar Arnfjörð Bjarmason, May 25, 2022
  255. 20/29 ci/run-test-slice.sh: replace shelling out with "echo"Ævar Arnfjörð Bjarmason, May 25, 2022
  256. 13/29 CI: remove "run-build-and-tests.sh", run "make [test]" directlyÆvar Arnfjörð Bjarmason, May 25, 2022
  257. 19/29 CI: move "env" definitions into ci/lib.shÆvar Arnfjörð Bjarmason, May 25, 2022
  258. 21/29 CI: pre-select test slice in Windows & VS testsÆvar Arnfjörð Bjarmason, May 25, 2022
  259. 22/29 CI: only invoke ci/lib.sh as "steps" in main.ymlÆvar Arnfjörð Bjarmason, May 25, 2022
  260. 23/29 CI: narrow down variable definitions in --build and --testÆvar Arnfjörð Bjarmason, May 25, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.