Re: [PATCH v3 25/29] CI: set CC in MAKEFLAGS directly, don't add it to the environment
- From
Carlo Arenas <carenas@gmail.com>
- Date
- Apr 15, 2022, 02:21 UTC
- Message-ID
- <CAPUEspjT23rqBwkgARf90me1n0dd4pjS4i+ya=Vo=xCBCTjp4g@mail.gmail.com>
- In-Reply-To
- <patch-v3-25.29-1268792233f-20220413T194847Z-avarab@gmail.com>
On Wed, Apr 13, 2022 at 12:52 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
Show 7 quoted lines
> @@ -160,13 +169,23 @@ linux-TEST-vars) > setenv --test GIT_TEST_WRITE_REV_INDEX 1 > setenv --test GIT_TEST_CHECKOUT_WORKERS 2 > ;; > +osx-gcc) > + CC=gcc > + CC_PACKAGE=gcc-9
not sure when this was broken since there were too many refactorings around this code, but this is definitely wrong.
macos' gcc is really clang, so if we really want to build with gcc instead (and there are 9, 10 and 11 versions installed) need to use instead (for version 9, which was what was used originally and what CC_PACKAGE was installing if needed)
CC=gcc-9
Right now both macos jobs are using clang, regardless of what the nicely named label says.
Carlo