Re: [PATCH v4 1/6] t: move reftable/stack_test.c to the unit testing framework
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 4, 2024, 17:17 UTC
- Message-ID
- <xmqqmskn9w3o.fsf@gitster.g>
- In-Reply-To
- <20240904150132.11567-2-chandrapratap3519@gmail.com>
Chandra Pratap <chandrapratap3519@gmail.com> writes:
Show 6 quoted lines
> int cmd__reftable(int argc, const char **argv)
> {
> /* test from simple to complex. */
> - stack_test_main(argc, argv);
> return 0;
> }This makes cmd__reftable() a no-op.
Even though you cannot remove t/helpter/test-reftable.c, as it contains the implementation for "test-tool dump-reftable", we should at least be able to do something like this.
--- >8 --- Subject: [PATCH 7/6] t: clean up leftover reftable test cruft
With migration of the tests of the reftable to the unit-tests framework, "test-tool reftable" has become an expensive no-op.
Retire everything that uses "test-tool reftable", and everything that is used to implement it.
While at it, make the cmds[] list alphabetically sorted again by moving the entry for "dump-reftable".
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- t/helper/test-reftable.c | 6 ------ t/helper/test-tool.c | 3 +-- t/helper/test-tool.h | 1 - t/t0032-reftable-unittest.sh | 16 ---------------- 4 files changed, 1 insertion(+), 25 deletions(-)
diff --git c/t/helper/test-reftable.c w/t/helper/test-reftable.c index d27d7ee798..e62298c6a4 100644 --- c/t/helper/test-reftable.c +++ w/t/helper/test-reftable.c @@ -9,12 +9,6 @@ #include "reftable/reftable-tests.h" #include "test-tool.h" -int cmd__reftable(int argc, const char **argv) -{ - /* test from simple to complex. */ - return 0; -} - static void print_help(void) { printf("usage: dump [-st] arg\n\n" diff --git c/t/helper/test-tool.c w/t/helper/test-tool.c index f8a67df7de..252fa5de63 100644 --- c/t/helper/test-tool.c +++ w/t/helper/test-tool.c @@ -26,6 +26,7 @@ static struct test_cmd cmds[] = { { "drop-caches", cmd__drop_caches }, { "dump-cache-tree", cmd__dump_cache_tree }, { "dump-fsmonitor", cmd__dump_fsmonitor }, + { "dump-reftable", cmd__dump_reftable }, { "dump-split-index", cmd__dump_split_index }, { "dump-untracked-cache", cmd__dump_untracked_cache }, { "env-helper", cmd__env_helper }, @@ -61,9 +62,7 @@ static struct test_cmd cmds[] = { { "read-graph", cmd__read_graph }, { "read-midx", cmd__read_midx }, { "ref-store", cmd__ref_store }, - { "reftable", cmd__reftable }, { "rot13-filter", cmd__rot13_filter }, - { "dump-reftable", cmd__dump_reftable }, { "regex", cmd__regex }, { "repository", cmd__repository }, { "revision-walking", cmd__revision_walking }, diff --git c/t/helper/test-tool.h w/t/helper/test-tool.h index e74bc0ffd4..84291318cb 100644 --- c/t/helper/test-tool.h +++ w/t/helper/test-tool.h @@ -55,7 +55,6 @@ int cmd__read_graph(int argc, const char **argv); int cmd__read_midx(int argc, const char **argv); int cmd__ref_store(int argc, const char **argv); int cmd__rot13_filter(int argc, const char **argv); -int cmd__reftable(int argc, const char **argv); int cmd__regex(int argc, const char **argv); int cmd__repository(int argc, const char **argv); int cmd__revision_walking(int argc, const char **argv); diff --git c/t/t0032-reftable-unittest.sh w/t/t0032-reftable-unittest.sh deleted file mode 100755 index 471cb37ac2..0000000000 --- c/t/t0032-reftable-unittest.sh +++ /dev/null @@ -1,16 +0,0 @@ -#!/bin/sh -# -# Copyright (c) 2020 Google LLC -# - -test_description='reftable unittests' - -TEST_PASSES_SANITIZE_LEAK=true -. ./test-lib.sh - -test_expect_success 'unittests' ' - TMPDIR=$(pwd) && export TMPDIR && - test-tool reftable -' - -test_done