Re: [PATCH v2 2/6] t: harmonize t-reftable-stack.c with coding guidelines
On Fri, Aug 23, 2024 at 05:18:47PM +0530, Chandra Pratap wrote:
Show 7 quoted lines
> @@ -1039,10 +1035,8 @@ static void t_reftable_stack_compaction_concurrent(void)
> static void unclean_stack_close(struct reftable_stack *st)
> {
> /* break abstraction boundary to simulate unclean shutdown. */
> - int i = 0;
> - for (; i < st->readers_len; i++) {
> + for (int i = 0; i < st->readers_len; i++)Nit: this should likely be `size_t i`. Not worth a reroll on its own
though.
Patrick
Patrick Steinhardt <ps@pks.im>