Re: [PATCH v6 4/6] t-reftable-stack: use reftable_ref_record_equal() to compare ref records

From: Patrick Steinhardt <ps@pks.im>
Date: Sep 9, 2024, 11:42 UTC
Message-ID: <Zt7fDSjqqKMW2lKG@pks.im>
In-Reply-To: <20240908041632.4948-5-chandrapratap3519@gmail.com>

On Sun, Sep 08, 2024 at 09:35:59AM +0530, Chandra Pratap wrote:

Show 7 quoted lines

> In the current stack tests, ref records are compared for equality
> by sometimes using the dedicated function for ref-record comparison,
> reftable_ref_record_equal(), and sometimes by explicity comparing
> contents of the ref records.
> 
> The latter method is undesired because there can exist unequal ref
> records with the some of the contents being equal. Replace the latter

s/the some/some

Not worth a reroll, just pointing it out in case you end up rerolling due to other issues.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.