Re: [GSoC][PATCH v3 0/6] t: port reftable/stack_test.c to the unit testing framework

From: Chandra Pratap <chandrapratap3519@gmail.com>
Date: Aug 26, 2024, 18:34 UTC
Message-ID: <CA+J6zkQKc=NmBnuih9Y+2oMjQtVOhKxJ_RfOLGxvWxcBbMH+kA@mail.gmail.com>
In-Reply-To: <xmqqcylvjhtt.fsf@gitster.g>

On Mon, 26 Aug 2024 at 23:18, Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

>
> Chandra Pratap <chandrapratap3519@gmail.com> writes:
>
> > Changes in v2:
> > - Use 'size_t' as array index instead of 'int' in a test that is
> >   modified in patch 2.
> > - Fix a coding style violation in the newly introduced test in
> >   patch 6.
>
> If I recall correctly, the first iteration conflicted too badly with
> other topics in flight, and kept out of 'seen' so far.

Yeah, I remember Patrick was working on some other patch series involving 'reftable/stack_test.c' which caused conflicts with this series. I _did_ make sure to rebase this series on top of that one.

> Have you tested this series, not just standalone, but see how well
> it works together with other topics by creating trial merges of it into
> 'next' and 'seen'?

I did notice some small Makefile conflicts with the latest 'master' on the GitHub CI, but other than that, no, I haven't checked the patch against 'next' or 'seen'.

> It some other topics that conflict with what you do in this topic
> have advanced (or better yet, graduated to 'master'), it may not be
> a bad idea to consider rebasing the topic to more recent 'master',
> possibly merging other topics into it first.

I generally make sure to rebase my patches on top of the latest master before sending them to the mailing list. I'll add 'next' and 'seen' to my checklist as well.