Re: [PATCH v4 1/6] t: move reftable/stack_test.c to the unit testing framework
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Sep 5, 2024, 07:15 UTC
- Message-ID
- <ZtlafDnM-geVUTQ9@pks.im>
- In-Reply-To
- <xmqqmskn9w3o.fsf@gitster.g>
On Wed, Sep 04, 2024 at 10:17:47AM -0700, Junio C Hamano wrote:
Show 14 quoted lines
> Chandra Pratap <chandrapratap3519@gmail.com> writes:
>
> > int cmd__reftable(int argc, const char **argv)
> > {
> > /* test from simple to complex. */
> > - stack_test_main(argc, argv);
> > return 0;
> > }
>
> This makes cmd__reftable() a no-op.
>
> Even though you cannot remove t/helpter/test-reftable.c, as it
> contains the implementation for "test-tool dump-reftable", we should
> at least be able to do something like this.In addition to Junio's patch you can also remove "reftable/reftable-tests.h".
Patrick