git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: AW: [PATCH 1/2] stash--helper: implement "git stash--helper"

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 29, 2016, 19:58 UTC
Message-ID
<xmqqlh78ximf.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<BLU436-SMTP10996033F3EBFE2E8639F96A5DB0@phx.gbl>
Matthias Aßhauer <mha1993@live.de> writes:
[administrivia: please wrap your lines to reasonable lengths]
Show 7 quoted lines
>> Honestly, I had high hopes after seeing the "we are rewriting it
>> in C" but I am not enthused after seeing this.  I was hoping that
>> the rewritten version would do this all in-core, by calling these
>> functions that we already have:
>
> These functions might be obvious to you, but I'm new to git's
> source code, ...

Ahh, I didn't realize I was talking with somebody unfamiliar with the codebase. Apologies.

Nevertheless, the list of functions I gave are a good starting point; they are widely used building blocks in the codebase.

> I'll be working on a v2 that incorporates the feedback from you,
> Thomas Gummerer and Stefan Beller then. Further feedback is of
> course welcome.
Thanks.
Previous: Matthias AßhauerNext: Michael Blume
Message 12 of 14 in “stash--helper: implement "git stash--helper"”
  1. 1/2 stash--helper: implement "git stash--helper"Matthias Asshauer, Jan 28, 2016
  2. 2/2 stash: use "stash--helper"Matthias Asshauer, Jan 28, 2016
  3. Stefan BellerJan 28, 2016
  4. AW: [PATCH 2/2] stash: use "stash--helper"Matthias Aßhauer, Jan 28, 2016
  5. Stefan BellerJan 28, 2016
  6. Roberto TyleyJan 28, 2016
  7. AW: [PATCH 2/2] stash: use "stash--helper"Matthias Aßhauer, Jan 29, 2016
  8. Thomas GummererJan 29, 2016
  9. Junio C HamanoJan 29, 2016
  10. Junio C HamanoJan 28, 2016
  11. AW: [PATCH 1/2] stash--helper: implement "git stash--helper"Matthias Aßhauer, Jan 29, 2016
  12. Junio C HamanoJan 29, 2016
  13. Michael BlumeFeb 1, 2016
  14. Junio C HamanoFeb 1, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.