From: Junio C Hamano Date: Fri, 29 Jan 2016 19:58:48 GMT Subject: Re: AW: [PATCH 1/2] stash--helper: implement "git stash--helper" Message-ID: In-Reply-To: Matthias Aßhauer writes: [administrivia: please wrap your lines to reasonable lengths] >> Honestly, I had high hopes after seeing the "we are rewriting it >> in C" but I am not enthused after seeing this. I was hoping that >> the rewritten version would do this all in-core, by calling these >> functions that we already have: > > These functions might be obvious to you, but I'm new to git's > source code, ... Ahh, I didn't realize I was talking with somebody unfamiliar with the codebase. Apologies. Nevertheless, the list of functions I gave are a good starting point; they are widely used building blocks in the codebase. > I'll be working on a v2 that incorporates the feedback from you, > Thomas Gummerer and Stefan Beller then. Further feedback is of > course welcome. Thanks.