Re: AW: [PATCH 1/2] stash--helper: implement "git stash--helper"
- From
Michael Blume <blume.mike@gmail.com>
- Date
- Feb 1, 2016, 23:36 UTC
- Message-ID
- <CAO2U3QhvibfEexCUuDJyj=4P+bebnrQhMaVq3VrgNBLbiTDNaA@mail.gmail.com>
- In-Reply-To
- <xmqqlh78ximf.fsf@gitster.mtv.corp.google.com>
On Fri, Jan 29, 2016 at 11:58 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 27 quoted lines
> Matthias Aßhauer <mha1993@live.de> writes: > > [administrivia: please wrap your lines to reasonable lengths] > >>> Honestly, I had high hopes after seeing the "we are rewriting it >>> in C" but I am not enthused after seeing this. I was hoping that >>> the rewritten version would do this all in-core, by calling these >>> functions that we already have: >> >> These functions might be obvious to you, but I'm new to git's >> source code, ... > > Ahh, I didn't realize I was talking with somebody unfamiliar with > the codebase. Apologies. > > Nevertheless, the list of functions I gave are a good starting > point; they are widely used building blocks in the codebase. > >> I'll be working on a v2 that incorporates the feedback from you, >> Thomas Gummerer and Stefan Beller then. Further feedback is of >> course welcome. > > Thanks. > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Maybe this isn't important given that it looks like the patch is going to be rewritten, but I have
stash.c:43:18: warning: incompatible pointer types assigning to 'const
char *const *' from 'const char *'; take the address with &
[-Wincompatible-pointer-types]
write_tree.env = prefix;