Re: [PATCH 2/2] stash: use "stash--helper"

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 29, 2016, 18:34 UTC
Message-ID: <xmqq8u38jkua.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160129112152.GO7100@hank>

Thomas Gummerer <t.gummerer@gmail.com> writes:

Show 18 quoted lines

> Matthias, feel free to squash the following (or something similar) in
> when you re-roll.
>
> diff --git a/t/perf/p3000-stash.sh b/t/perf/p3000-stash.sh
> new file mode 100755
> index 0000000..e6e1153
> --- /dev/null
> +++ b/t/perf/p3000-stash.sh
> @@ -0,0 +1,20 @@
> +#!/bin/sh
> +
> +test_description="Test performance of git stash"
> +
> +. ./perf-lib.sh
> +
> +test_perf_default_repo
> +
> +file=$(git ls-files | tail -n 30 | head -1)

If you use "tail -n 30" not "tail -30", which is good manners, you would want to be consistent and say "head -n 1".

Show 11 quoted lines

> +
> +test_expect_success "prepare repository" "
> +	echo x >$file
> +"
> +
> +test_perf "stash/stash pop" "
> +	git stash &&
> +	git stash pop
> +"
> +
> +test_done