git/list[1] front-page[2] threads[3] people[4] search[5] about
 

AW: [PATCH 2/2] stash: use "stash--helper"

From
Matthias Aßhauer <mha1993@live.de>
Date
Jan 28, 2016, 21:25 UTC
Message-ID
<BLU436-SMTP572EDBE67B8D37ECADD616A5DA0@phx.gbl>
In-Reply-To
<CAGZ79kaPQP+-LpW8ExM2wmfftW4_oa7tB5XdfsdC8XHwH4aFOA@mail.gmail.com>
> You had some good measurements in the coverletter, which is not going to be recorded in the projects history. This part however would be part of the commit.
> So you could move the speed improvements here (as well as the other reasoning) on why this is a good idea. :)
I considered that, but I thought it would inflate the size of the commit message quite a bit and represents a  pretty temporary information as I'm planning to port more code. Any further progression on this would make the old meassurements kind of obsolete IMHO. I decided to move it to the coverletter, because it is only valid information if you consider both commits. If the general opinion on here is that I should add it to the commit message though, I'll gladly update it.
>> https://github.com/git/git/pull/191
>
> Oh I see you're using the pull-request to email translator, cool! 
Yes, I did. It definitly makes things easier if you are not used to mailing lists, but it was also a bit of a kerfuffle. I tried to start working on coverletter support, but I couldn't get it to accept the amazon SES credentials I provided. I ended up manually submiting the coverletter. It also didn't like my name.
Thank you for your quick feedback. 
Previous: Stefan BellerNext: Stefan Beller
Message 4 of 14 in “stash--helper: implement "git stash--helper"”
  1. 1/2 stash--helper: implement "git stash--helper"Matthias Asshauer, Jan 28, 2016
  2. 2/2 stash: use "stash--helper"Matthias Asshauer, Jan 28, 2016
  3. Stefan BellerJan 28, 2016
  4. AW: [PATCH 2/2] stash: use "stash--helper"Matthias Aßhauer, Jan 28, 2016
  5. Stefan BellerJan 28, 2016
  6. Roberto TyleyJan 28, 2016
  7. AW: [PATCH 2/2] stash: use "stash--helper"Matthias Aßhauer, Jan 29, 2016
  8. Thomas GummererJan 29, 2016
  9. Junio C HamanoJan 29, 2016
  10. Junio C HamanoJan 28, 2016
  11. AW: [PATCH 1/2] stash--helper: implement "git stash--helper"Matthias Aßhauer, Jan 29, 2016
  12. Junio C HamanoJan 29, 2016
  13. Michael BlumeFeb 1, 2016
  14. Junio C HamanoFeb 1, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.