Re: [PATCH 3/3] t7421: eliminate 'grep' check in t7421.4 for mingw compatibility

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 25, 2020, 16:10 UTC
Message-ID: <xmqqlfi21zb8.fsf@gitster.c.googlers.com>
In-Reply-To: <2a1ea501-4974-4d74-fe3c-d173bbe76855@gmail.com>

Kaartic Sivaraam <kaartic.sivaraam@gmail.com> writes:

Show 12 quoted lines

>> @@ -1061,8 +1061,9 @@ static void generate_submodule_summary(struct summary_cb *info,
>>  	}
>>  
>>  	if (S_ISGITLINK(p->mod_src)) {
>> -		src_abbrev = verify_submodule_committish(p->sm_path,
>> -							 oid_to_hex(&p->oid_src));
>> +		if (p->status != 'D')
>> +			src_abbrev = verify_submodule_committish(p->sm_path,
>> +								 oid_to_hex(&p->oid_src));
>>  		if (!src_abbrev) {
>>  			missing_src = 1;
>>  			/*

Interesting. There is a mirroring if-else cascade that begins with "if (S_ISGITLINK(p->mod_dst))" immediately after the if-else cascade started here, and in there, the same verify_submodule_committish() is called for oid_dst unconditionally. Should the asymmetry bother readers of the code, or is the source side somehow special and needs extra care?