git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] t7421: eliminate 'grep' check in t7421.4 for mingw compatibility

From
Shourya Shukla <shouryashukla.oo@gmail.com>
Date
Aug 27, 2020, 09:14 UTC
Message-ID
<20200827091441.GA6656@konoha>
In-Reply-To
<xmqqlfi21zb8.fsf@gitster.c.googlers.com>
Show 6 quoted lines
> Interesting.  There is a mirroring if-else cascade that begins with
> "if (S_ISGITLINK(p->mod_dst))" immediately after the if-else cascade
> started here, and in there, the same verify_submodule_committish()
> is called for oid_dst unconditionally.  Should the asymmetry bother
> readers of the code, or is the source side somehow special and needs
> extra care?

I understand what you are trying to say. The thing is that the conditional `if (S_ISGITLINK(p->mod_dst))` already guards the `verify_submodule_committish` when we have a status of 'D'. So, we do not need another similar if-statement for that. It does seem a bit weird to someone who is reading this thing for the first time, hence, I will mention this in the commit message.

Apologies for the late reply, I was a little busy with something.
Previous: Junio C HamanoNext: Shourya Shukla
Message 10 of 12 in “submodule: fixup to summary-v3”
  1. Shourya ShuklaAug 25, 2020
  2. 2/3 submodule: fix style in function definitionShourya Shukla, Aug 25, 2020
  3. Junio C HamanoAug 25, 2020
  4. Shourya ShuklaAug 26, 2020
  5. Junio C HamanoAug 26, 2020
  6. 1/3 submodule: eliminate unused parameters from print_submodule_summary()Shourya Shukla, Aug 25, 2020
  7. 3/3 t7421: eliminate 'grep' check in t7421.4 for mingw compatibilityShourya Shukla, Aug 25, 2020
  8. Kaartic SivaraamAug 25, 2020
  9. Junio C HamanoAug 25, 2020
  10. Shourya ShuklaAug 27, 2020
  11. Shourya ShuklaAug 26, 2020
  12. Kaartic SivaraamAug 25, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.