git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] submodule: fix style in function definition

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 26, 2020, 16:47 UTC
Message-ID
<xmqq8se1we02.fsf@gitster.c.googlers.com>
In-Reply-To
<20200826094506.GA311769@konoha>
Shourya Shukla <shouryashukla.oo@gmail.com> writes:
Show 9 quoted lines
>>> The definitions of 'verify_submodule_committish()' and
>>> 'print_submodule_summary()' had wrong styling in terms of the asterisk
>>> placement. Amend them.
>
>> I pointed out only these two, but that does not necessarily mean
>> they are the only ones.  Have you checked all the new code added by
>> the series?
>
> There is one more. It is not related to my patch series though.

Cleaning up the existing breakage is outside the scope your series, but of course fixes as an independent patch is welcomed.

Thanks for checking.
Previous: Shourya ShuklaNext: Shourya Shukla
Message 5 of 12 in “submodule: fixup to summary-v3”
  1. Shourya ShuklaAug 25, 2020
  2. 2/3 submodule: fix style in function definitionShourya Shukla, Aug 25, 2020
  3. Junio C HamanoAug 25, 2020
  4. Shourya ShuklaAug 26, 2020
  5. Junio C HamanoAug 26, 2020
  6. 1/3 submodule: eliminate unused parameters from print_submodule_summary()Shourya Shukla, Aug 25, 2020
  7. 3/3 t7421: eliminate 'grep' check in t7421.4 for mingw compatibilityShourya Shukla, Aug 25, 2020
  8. Kaartic SivaraamAug 25, 2020
  9. Junio C HamanoAug 25, 2020
  10. Shourya ShuklaAug 27, 2020
  11. Shourya ShuklaAug 26, 2020
  12. Kaartic SivaraamAug 25, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.