Re: [PATCH v3 5/5] gitlab-ci: add whitespace error check

From: Junio C Hamano <gitster@pobox.com>
Date: May 6, 2024, 17:17 UTC
Message-ID: <xmqqle4mzwp8.fsf@gitster.g>
In-Reply-To: <Zjh-3dCL2-MnV-PE@tanuki>

Patrick Steinhardt <ps@pks.im> writes:

Show 9 quoted lines

>> +check-whitespace:
>> +  image: ubuntu:latest
>> +  before_script:
>> +    - ./ci/install-dependencies.sh
>
> Do we actually need to install dependencies? I imagine all that's needed
> would be Git.
>
> Other than this question the patch series looks good to me, thanks!

I am a bit puzzled. Is the proposal to check our sources with a pre-built Git (which by definition would be a bit older than what is being tested)?

Not that I have serious trouble in that direction---I am just trying to make sure what is being proposed.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.