Re: [PATCH 2/2] gitlab-ci: add whitespace error check

From: Patrick Steinhardt <ps@pks.im>
Date: Apr 30, 2024, 05:04 UTC
Message-ID: <ZjB79eQbuQKrTzF8@tanuki>
In-Reply-To: <5p5ot4juki7v2lycups4jhadxcw5yzpqtjkwgxzwrlrpu6mlmt@gis6xmwjjh6o>

On Mon, Apr 29, 2024 at 10:01:15PM -0500, Justin Tobler wrote:

Show 15 quoted lines

> On 24/04/30 11:59AM, James Liu wrote:
> > Thanks for putting this together, Justin!
> > 
> > > +check-whitespace:
> > > +  image: ubuntu:latest
> > 
> > I wonder if we should pin to `ubuntu:22.04` and only update this for
> > each LTS release. It seems like we've done this for the
> > `static-analysis` job above.
> 
> I'm not sure if it particually matters. I know Patrick recently
> submitted the following also using `ubuntu:latest`:
> https://lore.kernel.org/git/01fb94999f8e2014ba4d09ce7451a4f5d315ee72.1714371146.git.ps@pks.im/#r
> 
> I can change it though if there is strong opinion one way or the other.

I'd say it probably doesn't matter much for this case. But using `ubuntu:latest` means that there's less maintenance going forward because we don't ever have to update it.

Patrick